Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: Expose SGX EPC resource #1129

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Apr 13, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from jjacobelli and kad April 13, 2023 19:17
@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit de1b69a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/643947c8ac053600081682b1
😎 Deploy Preview https://deploy-preview-1129--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mythi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2023
docs/usage/features.md Outdated Show resolved Hide resolved
docs/usage/customization-guide.md Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Apr 14, 2023

@mythi you can now rebase
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2023
@marquiz
Copy link
Contributor

marquiz commented Apr 14, 2023

/milestone v0.13.0

@k8s-ci-robot k8s-ci-robot added this to the v0.13.0 milestone Apr 14, 2023
@mythi mythi marked this pull request as ready for review April 14, 2023 16:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zvonkok April 14, 2023 16:01
@mythi
Copy link
Contributor Author

mythi commented Apr 14, 2023

Tested with the following setup and it works as expected:

apiVersion: nfd.k8s-sigs.io/v1alpha1
kind: NodeFeatureRule
metadata:
  name: sgx-epc-rule
spec:
  rules:
  - name: "SGX EPC"
    extendedResources:
      sgx.intel.com/epc2: "@cpu.security.sgx.epc"
    matchFeatures:
      - feature: cpu.security
        matchExpressions:
          sgx.enabled: {op: IsTrue}

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @mythi! Just in time for v0.13 😎

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@marquiz
Copy link
Contributor

marquiz commented Apr 14, 2023

/assign @zvonkok

@zvonkok
Copy link
Contributor

zvonkok commented Apr 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 76dd0ebc7f49c2480b283f663b49160da080f069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants