Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfd-master: re-try on node update failures #1127

Merged
merged 1 commit into from
Apr 13, 2023
Merged

nfd-master: re-try on node update failures #1127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/nfd-master/nfd-master.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,21 +329,25 @@ func (m *nfdMaster) nfdAPIUpdateHandler() {
case <-rateLimit:
// Check what we need to do
// TODO: we might want to update multiple nodes in parallel
errUpdateAll := false
errNodes := make(map[string]struct{})
if updateAll {
if err := m.nfdAPIUpdateAllNodes(); err != nil {
klog.Error(err)
errUpdateAll = true
}
} else {
for nodeName := range updateNodes {
if err := m.nfdAPIUpdateOneNode(nodeName); err != nil {
klog.Error(err)
errNodes[nodeName] = struct{}{}
}
}
}

// Reset "work queue" and timer
updateAll = false
updateNodes = make(map[string]struct{})
// Reset "work queue" and timer, will cause re-try if errors happened
updateAll = errUpdateAll
updateNodes = errNodes
rateLimit = time.After(time.Second)
}
}
Expand Down