Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfd-master: increase controller resync period to 1 hour #1123

Merged
merged 1 commit into from
Apr 12, 2023
Merged

nfd-master: increase controller resync period to 1 hour #1123

merged 1 commit into from
Apr 12, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Apr 12, 2023 •
edited
Loading

Increase the NFD API controller resync period from 5 minutes to 1 hour.
The resync causes nfd-master to replay all NodeFeature and
NodeFeatureRule objects, being effectively a "big hammer reset all"
button. This should only be needed as an "insurance" to fix labels et al
in case they have been manually tampered (outside NFD) and against
certain bugs in nfd itself. NFD is not supposed to manage anything
fast-changing so 1 hour should be enough.

This change only affects behavior when the NodeFeature API has been
enabled (with -enable-nodefeature-api).

@k8s-ci-robot k8s-ci-robot requested review from fmuyassarov and kad April 12, 2023 12:04
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2023
@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 70ac19e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6436b488639e5a000870285d
😎 Deploy Preview https://deploy-preview-1123--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Apr 12, 2023

TBH I have little clue what would be the "right value" for the resync period, it could be even hours I think 😇 Any thoughts @ArangoGutierrez @zvonkok @PiotrProkop et al?

@PiotrProkop
Copy link
Contributor

TBH I have little clue what would be the "right value" for the resync period, it could be even hours I think 😇 Any thoughts @ArangoGutierrez @zvonkok @PiotrProkop et al?

I would go ahead and change it to 1 * time.Hour.

@marquiz
nfd-master: increase controller resync period to 1 hour
70ac19e 
Increase the NFD API controller resync period from 5 minutes to 1 hour.
The resync causes nfd-master to replay all NodeFeature and
NodeFeatureRule objects, being effectively a "big hammer reset all"
button. This should only be needed as an "insurance" to fix labels et al
in case they have been manually tampered (outside NFD) and against
certain bugs in nfd itself. NFD is not supposed to manage anything
fast-changing so 1 hour should be enough.

This change only affects behavior when the NodeFeature API has been
enabled (with -enable-nodefeature-api).
@marquiz marquiz force-pushed the devel/master-resync branch from 7079c46 to 70ac19e Compare April 12, 2023 13:39
@marquiz
Copy link
Contributor Author

marquiz commented Apr 12, 2023

I would go ahead and change it to 1 * time.Hour.

Sold 😅 Increased to one hour now

/retitle nfd-master: increase controller resync period to 1 hour

@k8s-ci-robot k8s-ci-robot changed the title nfd-master: increase controller resync period to 10 min nfd-master: increase controller resync period to 1 hour Apr 12, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Apr 12, 2023

/assign @ArangoGutierrez

ArangoGutierrez
ArangoGutierrez approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a flag/NFDmaster config option to edit this by the user in the future

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Apr 12, 2023

We should add a flag/NFDmaster config option to edit this by the user in the future

Agree, for v0.14.0

@marquiz
Copy link
Contributor Author

marquiz commented Apr 12, 2023

Added #1124

@ArangoGutierrez
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8bdb176e25f0085a590b6b0253eed9dac5f20544

@k8s-ci-robot k8s-ci-robot merged commit e75be0b into kubernetes-sigs:master Apr 12, 2023
@marquiz marquiz deleted the devel/master-resync branch April 12, 2023 19:43
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@kad kad Awaiting requested review from kad

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @PiotrProkop @k8s-ci-robot @ArangoGutierrez