Skip to content

Commit

Permalink
nfd-master: increase controller resync period to 10 min
Browse files Browse the repository at this point in the history
Increase the NFD API controller resync period from 5 to 10 minutes. The
resync causes nfd-master to replay all NodeFeature and NodeFeatureRule
objects, being effectively a "big hammer reset all" button. This should
only be needed as an "insurance" to fix labels et al in case they have
been manually tampered (outside NFD) and against certain bugs in nfd
itself. NFD is not supposed to manage anything fast-changing so 10
minutes should be enough.

This change only affects behavior when the NodeFeature API has been
enabled (with -enable-nodefeature-api).
  • Loading branch information
marquiz committed Apr 12, 2023
1 parent fe1db97 commit 7079c46
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/nfd-master/nfd-api-controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func newNfdController(config *restclient.Config, disableNodeFeature bool) (*nfdC

nfdClient := nfdclientset.NewForConfigOrDie(config)

informerFactory := nfdinformers.NewSharedInformerFactory(nfdClient, 5*time.Minute)
informerFactory := nfdinformers.NewSharedInformerFactory(nfdClient, 10*time.Minute)

// Add informer for NodeFeature objects
if !disableNodeFeature {
Expand Down

0 comments on commit 7079c46

Please sign in to comment.