Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: append _test suffix to test files #1029

Merged
merged 1 commit into from
Jan 11, 2023
Merged

e2e: append _test suffix to test files #1029

merged 1 commit into from
Jan 11, 2023
+0 −0

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Jan 11, 2023

This PR is a result of conversation started here:
#1028 (comment)

Signed-off-by: Talor Itzhak [email protected]

@Tal-or
e2e: append _test suffix to test files
d8981f8 
This PR is a result of conversation started here:
kubernetes-sigs#1028 (comment)

Signed-off-by: Talor Itzhak <[email protected]>
@netlify
Copy link

netlify bot commented Jan 11, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit d8981f8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63bea896afe4600008596dda
😎 Deploy Preview https://deploy-preview-1029--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Tal-or. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2023
@Tal-or Tal-or mentioned this pull request Jan 11, 2023
Merged
@fmuyassarov
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2023
fmuyassarov
fmuyassarov reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c61cfa689e5d6277d7d62561c09a5dabe19cfee2

marquiz
marquiz approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tal-or 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 677783e into kubernetes-sigs:master Jan 11, 2023
@Tal-or Tal-or deleted the rename_test_files branch January 11, 2023 14:45
@Tal-or Tal-or mentioned this pull request Mar 6, 2023
Closed
9 tasks
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@marquiz marquiz marquiz approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tal-or @k8s-ci-robot @fmuyassarov @marquiz