e2e: init docker image

[Tal-or]

The docker image that used during e2e test
composed of repo and tag flags that are
passed to the test itself.

The problem is that the docker image initialized
before the flags are parsed. Hence, it will always contains the default flags value.
Initialize the flag in later stage, fixing the issue.

Also, moving the global variables to e2e_test.go since it commonly used by all tests.

Signed-off-by: Talor Itzhak [email protected]

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	97ca4de
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63becb8f8004430009eb3b61
😎 Deploy Preview	https://deploy-preview-1028--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[k8s-ci-robot]

Hi @Tal-or. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Tal-or]

@marquiz I would also append the test suffix for the test files:
node_feature_discovery_test.go
topology_updater_test.go
so the global variables would be recognized in modern IDE's such as Goland.

WDYT?

[marquiz]

Uh-oh, thanks @Tal-or for catching this one. I had just one suggestion to drop the "caching" variable for good

ping @fmuyassarov

[marquiz]

I would also append the test suffix for the test files:
node_feature_discovery_test.go
topology_updater_test.go
so the global variables would be recognized in modern IDE's such as Goland.

Sure, go ahead, I don't have anything against that. But probably in a separate PR (?)

[Tal-or]

I would also append the test suffix for the test files:
node_feature_discovery_test.go
topology_updater_test.go
so the global variables would be recognized in modern IDE's such as Goland.

Sure, go ahead, I don't have anything against that. But probably in a separate PR (?)

Done #1029

[fmuyassarov]

/ok-to-test
/lgtm
Thanks for the fix.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 3cddc067abf5cb61a647eafe8be19f8710a15c92

[marquiz]

Ach, needs rebase 🙃 Otherwise LGTM

[Tal-or]

Ach, needs rebase upside_down_face Otherwise LGTM

Done

[marquiz]

Thx @Tal-or!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a58d3ff3b0ff50b12fde1292741cf2b0a1d0ee79

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marquiz]

/cherry-pick release-0.12

[k8s-infra-cherrypick-robot]

@marquiz: #1028 failed to apply on top of branch "release-0.12":

Applying: e2e: init docker image
Using index info to reconstruct a base tree...
A	test/e2e/node_feature_discovery_test.go
A	test/e2e/topology_updater_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/node_feature_discovery.go
CONFLICT (content): Merge conflict in test/e2e/node_feature_discovery.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 e2e: init docker image
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.