Helm chart release v3.9.0 #1228
Conversation
Issue: kubernetes-sigs#1219 Problem: when labels for the service are defined they will also show in the annotations Signed-off-by: JoaoBraveCoding <[email protected]>
Signed-off-by: Steve Hipwell <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
approved
|
/retest |
|
/assign @dgrisonnet @serathius |
|
Why do we backport the change to release-0.6? I thought that chart is developed on master branch and is disconnected from metrics-server releases. Maybe we had the discussion I just forgot. |
|
@serathius it was requested that the chart be released from the release branch. I think this was either for the first v0.6 chart release or shortly afterwards. I also think it was due to testing constraints external to the actual chart. I got it slightly wrong last time in that changes should go to main before the release branch while the release is latest so it's easier to see the latest version. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR releases the
v3.9.0Helm chart which includes metrics Serverv0.6.3.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1213