Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patch remover #1242

Merged
merged 7 commits into from
Jun 25, 2019
Merged

Add patch remover #1242

merged 7 commits into from
Jun 25, 2019

Conversation

taxpon
Copy link
Contributor

@taxpon taxpon commented Jun 24, 2019

  • Add remove command for patch
# Removes one or more patches from the kustomization file
kustomize edit remove patch <filepath>

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taxpon
To complete the pull request process, please assign justinsb
You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2019
@taxpon
Copy link
Contributor Author

taxpon commented Jun 24, 2019

/assign @justinsb

monopole
monopole suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, just some minor nits

pkg/commands/edit/remove/removepatch.go Show resolved Hide resolved
pkg/commands/edit/remove/removepatch.go Show resolved Hide resolved
pkg/commands/edit/remove/removepatch_test.go Outdated Show resolved Hide resolved
pkg/commands/edit/remove/util.go Outdated Show resolved Hide resolved
pkg/commands/edit/remove/util.go Outdated Show resolved Hide resolved
pkg/patch/strategicmerge_test.go Outdated Show resolved Hide resolved
@taxpon
Copy link
Contributor Author

taxpon commented Jun 25, 2019

@monopole Thank you for reviewing! I applied your feedbacks. Pls, review this again.

monopole
monopole approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
@monopole monopole merged commit 762d314 into kubernetes-sigs:master Jun 25, 2019
@taxpon taxpon deleted the add-patch-remover branch June 25, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole monopole approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@justinsb justinsb

@monopole monopole

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taxpon @k8s-ci-robot @monopole @justinsb