Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-78: Dynamically reclaiming resources #742

Merged
merged 5 commits into from
May 10, 2023

Conversation

trasc
Copy link
Contributor

@trasc trasc commented May 4, 2023

What type of PR is this?

/kind documentation
/kind api-change

What this PR does / why we need it:

One-line PR description: This KEP proposes an approach to reclaim unused resources of an unfinished job of cluster-queue in an incremental manner, so that all the resources of the cluster-queue can used efficiently.

Which issue(s) this PR fixes:

Relates to: #78

Special notes for your reviewer:

This is the continuation of #331, with an adaptation to the current state of Kueue.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit beaceb8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/645b99c3d8e493000893525c
😎 Deploy Preview https://deploy-preview-742--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@trasc trasc marked this pull request as ready for review May 4, 2023 07:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g May 4, 2023 07:09
@trasc trasc force-pushed the reclaim-KEP branch 2 times, most recently from 172b128 to 0f29e06 Compare May 4, 2023 07:16
@trasc
Copy link
Contributor Author

trasc commented May 4, 2023

/retest

keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
keps/78-dynamically-reclaiming-resources/README.md Outdated Show resolved Hide resolved
@trasc trasc force-pushed the reclaim-KEP branch 2 times, most recently from ee74fa8 to 50a772b Compare May 8, 2023 09:37
@trasc trasc force-pushed the reclaim-KEP branch 2 times, most recently from 0439378 to 814bb9e Compare May 9, 2023 10:45
@trasc
Copy link
Contributor Author

trasc commented May 9, 2023

/retest

Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 803f670 into kubernetes-sigs:main May 10, 2023
@trasc trasc deleted the reclaim-KEP branch May 11, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants