-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion about feature gate #740
Comments
We should probably follow the same feature-gate pattern as k/k. Are you thinking of a particular feature for which we need this? |
I'm working on the design of #331 , I think it would be more safe if we can provide such a mechanism, but at this point of time, we can have a flag to enable this. |
Regardless, feature flags might be useful. Would you want to add the framework for it? I wonder how much we can reuse from k/k. |
That's great.
I may need to take a look. |
For #78 I've opened another KEP PR #742, however , at least for the core components the implementation should be based on a optional field, which , if missing should give us the same behavior as before the implementation. But still we can use a feature gate to stop the |
I think linking this issue to #636 would be good. |
For some experimental features or huge changes which touch a lot of codes, we may need some protection mechanisms, the easiest way might be the config flags.
Or a really feature-gate kit.
The text was updated successfully, but these errors were encountered: