Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about feature gate #740

Closed
kerthcet opened this issue May 3, 2023 · 8 comments · Fixed by #788
Closed

Discussion about feature gate #740

kerthcet opened this issue May 3, 2023 · 8 comments · Fixed by #788
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kerthcet
Copy link
Contributor

kerthcet commented May 3, 2023

For some experimental features or huge changes which touch a lot of codes, we may need some protection mechanisms, the easiest way might be the config flags.

  • new introduced, enable via flag
  • mature, remove the flag, enable by default.

Or a really feature-gate kit.

@kerthcet kerthcet added the kind/feature Categorizes issue or PR as related to a new feature. label May 3, 2023
@alculquicondor
Copy link
Contributor

We should probably follow the same feature-gate pattern as k/k.

Are you thinking of a particular feature for which we need this?

@kerthcet
Copy link
Contributor Author

kerthcet commented May 3, 2023

I'm working on the design of #331 , I think it would be more safe if we can provide such a mechanism, but at this point of time, we can have a flag to enable this.

@alculquicondor
Copy link
Contributor

#331 is backed by issue #78, which is currently assigned to @trasc. I believe he's almost done with the design.

@alculquicondor
Copy link
Contributor

Regardless, feature flags might be useful. Would you want to add the framework for it? I wonder how much we can reuse from k/k.

@kerthcet
Copy link
Contributor Author

kerthcet commented May 4, 2023

I believe he's almost done with the design.

That's great.

Would you want to add the framework for it? I wonder how much we can reuse from k/k.

I may need to take a look.

@trasc
Copy link
Contributor

trasc commented May 4, 2023

For #78 I've opened another KEP PR #742, however , at least for the core components the implementation should be based on a optional field, which , if missing should give us the same behavior as before the implementation.

But still we can use a feature gate to stop the jobframework from populating that field.

@alculquicondor
Copy link
Contributor

@kerthcet did you make progress with feature gates?

#771 might benefit from it.

@tenzen-y
Copy link
Member

I think linking this issue to #636 would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants