reset admission check after deactivation

[KPostOffice]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3346
Fixes #3331

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Fix the flow of deactivation for workloads due to rejected AdmissionChecks. 
Now, all AdmissionChecks are reset back to the Pending state on eviction (and deactivation in particular), 
and so an admin can easily re-activate such a workload manually without tweaking the checks.

[k8s-ci-robot]

Welcome @KPostOffice!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @KPostOffice. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	8043dba
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67335b2ade58660008942c0d
😎 Deploy Preview	https://deploy-preview-3350--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[tenzen-y]

/ok-to-test

[mimowo]

cc @PBundyra

[mimowo]

@KPostOffice PTAL at the failures, maybe we could include as bugfix in 0.9.

[mimowo]

cc @PBundyra for a review pass. It seems the failing integration tests are for BookingExpired. PTAL.

[PBundyra]

Could you add a scenario for deactivated test, to observe transition from DeactivationTarget -> EvictedByDeactivation and resetting Workload's AdmissionChecks and RequeueState

[PBundyra]

Could we use a clock used in WorkloadController?

[PBundyra]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: f67d95d9c2f4924e2ab70e39f87c976a66e5ee98

[mimowo]

/release-note-edit

Fix the flow of deactivation for workloads due to rejected AdmissionChecks. 
Now, all AdmissionChecks are reset back to the Pending state on eviction (and deactivation in particular), 
and so an admin can easily re-activate such a workload manually without tweaking the checks.

[mimowo]

/approve
/cherry-pick release 0.9

[k8s-infra-cherrypick-robot]

@mimowo: once the present PR merges, I will cherry-pick it on top of release in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release 0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@mimowo: cannot checkout release: error checking out "release": exit status 1 error: pathspec 'release' did not match any file(s) known to git

In response to this:

/approve
/cherry-pick release 0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

/cherry-pick release-0.9

[k8s-infra-cherrypick-robot]

@mimowo: #3350 failed to apply on top of branch "release-0.9":

Applying: reset admission check after deactivation
Applying: adjust unit tests
Applying: use deactivation as prefix
Applying: use realClock in admissionCheck package
Applying: remove rejected check because it's transitory
Applying: swap order to avoid short circuit
Applying: dont duplicate eviction function
Using index info to reconstruct a base tree...
M	pkg/controller/core/workload_controller.go
M	pkg/workload/admissionchecks.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/workload/admissionchecks.go
CONFLICT (content): Merge conflict in pkg/workload/admissionchecks.go
Auto-merging pkg/controller/core/workload_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0007 dont duplicate eviction function

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

@KPostOffice can you work on preparing the cherry-pick?
You can use the hack/cherry_pick_pull.sh script.