Use DeactivationTarget to improve message when deactivating due to Rejected AdmissionChecks

[mimowo]

What would you like to be added:

When deactivating due to rejected admission checks we just active=false:

kueue/pkg/controller/core/workload_controller.go

Lines 370 to 379 in 3d278a9

	log.V(3).Info("Workload is evicted due to admission checks")
	if workload.HasRejectedChecks(wl) {
	wl.Spec.Active = ptr.To(false)
	if err := r.client.Update(ctx, wl); err != nil {
	return false, err
	}
	rejectedCheck := workload.RejectedChecks(wl)[0]
	r.recorder.Eventf(wl, corev1.EventTypeWarning, "AdmissionCheckRejected", "Deactivating workload because AdmissionCheck for %v was Rejected: %s", rejectedCheck.Name, rejectedCheck.Message)
	return true, nil
	}

Then, the generic message for the Evicted condition is set here.

The message can be improved when DeactivationTarget is used, see here.

The message candidate: The workload is deactivated due to rejected AdmissionChecks(s): check1, check2.

Why is this needed:

To inform the end user about the reason of deactivation.

[mimowo]

cc @PBundyra @tenzen-y @mbobrovskyi

[tenzen-y]

I was supposed to improve this mechanism in #1353.
So, I guess that @PBundyra is implementing this improvement now.

[mimowo]

I see @KPostOffice is already working on this under #3350

[mimowo]

/assign @KPostOffice

[k8s-ci-robot]

@mimowo: GitHub didn't allow me to assign the following users: KPostOffice.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @KPostOffice

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

@KPostOffice you should be able to assign yourself

[KPostOffice]

/assign