Use patch instead of update on jobframework multikueue adapters. #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
mbobrovskyi
force-pushed
the
cleanup/using-patch-instead-of-update
branch
from
cb84d7b
to
a2c55c0
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2ef490b493d6c0d7c8c2074babd44ae5b640915f
|
mimowo
reviewed
Jul 12, 2024
mbobrovskyi
force-pushed
the
cleanup/using-patch-instead-of-update
branch
from
a2c55c0
to
43fa190
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4fe895e7ab9a8712b71ae6aec9d32b5a95fee2c5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use
Patchinstead ofUpdateon jobframework multikueue adapters to prevent the risk of dropping fields.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Follow up for #2553 (comment).
Does this PR introduce a user-facing change?