Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use patch instead of update on jobframework. #2553

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Use patch instead of update on jobframework. #2553

merged 1 commit into from
Jul 11, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jul 8, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Use Patch instead of Update on jobframework to prevent the risk of dropping fields.

Which issue(s) this PR fixes:

Fixes #2269

Special notes for your reviewer:

Follow up for #2501 (comment).

Does this PR introduce a user-facing change?

Use Patch instead of Update on jobframework to prevent the risk of dropping fields.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc July 8, 2024 15:41
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 430a9bf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/669039457f64fc000873709f

@mbobrovskyi mbobrovskyi mentioned this pull request Jul 8, 2024
Merged
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch from 1f47014 to 0165633 Compare July 8, 2024 15:52
mimowo
mimowo reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit. cc @alculquicondor

pkg/controller/jobs/pod/pod_controller.go Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch from 0165633 to e0146fc Compare July 8, 2024 16:01
@mbobrovskyi
Copy link
Contributor Author

/retest

@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch 2 times, most recently from cf56865 to 4f3689b Compare July 9, 2024 10:21
@mbobrovskyi
Copy link
Contributor Author

/retest

mimowo
mimowo reviewed Jul 9, 2024
View reviewed changes
pkg/util/client/client.go Outdated Show resolved Hide resolved
mimowo
mimowo reviewed Jul 9, 2024
View reviewed changes
pkg/util/client/client.go Outdated Show resolved Hide resolved
@mimowo mimowo mentioned this pull request Jul 9, 2024
Closed
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch from 4f3689b to 26ccd4a Compare July 9, 2024 15:20
@alculquicondor
Copy link
Contributor

I want to review the whole thing from the previous version.
Please revert #2501 and incorporate in this PR.

@alculquicondor
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2024
@alculquicondor alculquicondor mentioned this pull request Jul 9, 2024
Merged
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch from 26ccd4a to aeeb3ab Compare July 9, 2024 21:09
@mbobrovskyi mbobrovskyi changed the title Optimise Patch and PatchStatus. Use patch instead of update on jobframework. Jul 9, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 9, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch from aeeb3ab to 26b24b4 Compare July 10, 2024 19:38
@mbobrovskyi
Copy link
Contributor Author

/hold cancel

Due to #2566 already fixed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
@mbobrovskyi
Copy link
Contributor Author

/retest

Due to insufficient computing.

@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch 2 times, most recently from 2565b20 to 47d49ff Compare July 10, 2024 20:33
@mbobrovskyi
Copy link
Contributor Author

/retest

Due to insufficient computing.

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Jul 11, 2024 •
edited
Loading

/test pull-kueue-test-e2e-main-1-27

Due to #2581

alculquicondor
alculquicondor reviewed Jul 11, 2024
View reviewed changes
pkg/controller/jobs/job/job_controller.go Outdated Show resolved Hide resolved
pkg/util/client/client.go Outdated Show resolved Hide resolved
pkg/controller/jobs/job/job_controller.go Outdated Show resolved Hide resolved
pkg/util/client/client.go Outdated Show resolved Hide resolved
pkg/controller/jobs/job/job_multikueue_adapter.go Outdated Show resolved Hide resolved
pkg/controller/jobs/pod/pod_controller.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-patch-and-patch-status branch from 47d49ff to 430a9bf Compare July 11, 2024 19:57
alculquicondor
alculquicondor reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 099ca25c315a841889c2fe48567b9820b2169f37

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@alculquicondor
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3e073a8 into kubernetes-sigs:main Jul 11, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 11, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/optimize-patch-and-patch-status branch July 11, 2024 20:30
@mbobrovskyi mbobrovskyi mentioned this pull request Jul 12, 2024
Merged
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Use patch instead of update on jobframework. (kubernetes-sigs#2553)
c47d782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@mimowo mimowo mimowo left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

Kueue might lose fields when admitting jobs
5 participants
@mbobrovskyi @alculquicondor @k8s-ci-robot @mimowo @tenzen-y