Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runs the race detector on integration tests. #2468

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Runs the race detector on integration tests. #2468

merged 1 commit into from
Jul 4, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jun 21, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Runs the race detector and emits any detected race conditions as the suite runs. If any are detected the suite is marked as failed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Follow up for #2460 (comment).

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 21, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 9c04d7b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6686c522d228930008eaef0d
😎 Deploy Preview https://deploy-preview-2468--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi mbobrovskyi marked this pull request as ready for review June 21, 2024 19:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2024
@mbobrovskyi mbobrovskyi marked this pull request as draft June 21, 2024 19:40
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2024
mszadkow
mszadkow approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@mszadkow mszadkow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - let's just fix the tests ;)

@mbobrovskyi
Copy link
Contributor Author

Yes, working on it on #2471.

@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch 2 times, most recently from c2078eb to 8f0680d Compare June 27, 2024 22:07
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

1 similar comment
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch from cf364a4 to 9b656e3 Compare June 28, 2024 04:27
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2024
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch from 9b656e3 to 8a537c4 Compare June 28, 2024 04:44
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch from 8a537c4 to ae82338 Compare June 28, 2024 04:47
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 28, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch from aa80f89 to c8a23ee Compare July 1, 2024 04:12
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch from c8a23ee to c519a7a Compare July 1, 2024 04:24
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch from c519a7a to c061e96 Compare July 1, 2024 04:39
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2024
@mbobrovskyi
Copy link
Contributor Author

/test all

This was referenced Jul 1, 2024
Merged
Merged
@mbobrovskyi mbobrovskyi force-pushed the cleanup/runs-the-race-detector-on-integration-tests branch from c061e96 to 9c04d7b Compare July 4, 2024 15:52
@mbobrovskyi mbobrovskyi marked this pull request as ready for review July 4, 2024 15:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor

alculquicondor
alculquicondor reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fde986c97ff185a94bca8b0ed4f71fb4825a8b02

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6c619c6 into kubernetes-sigs:main Jul 4, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 4, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/runs-the-race-detector-on-integration-tests branch July 4, 2024 17:48
@tenzen-y tenzen-y mentioned this pull request Oct 2, 2024
Closed
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Runs the race detector on integration tests. (kubernetes-sigs#2468)
1987074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mszadkow mszadkow mszadkow approved these changes

@kerthcet kerthcet Awaiting requested review from kerthcet

@trasc trasc Awaiting requested review from trasc

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@mbobrovskyi @k8s-ci-robot @alculquicondor @mszadkow