Fix race condition on delete workload from queue manager.

[mbobrovskyi]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix race condition on delete workload from queue manager.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I found it locally when test using golang.org/x/tools/cmd/stress.

WARNING: DATA RACE
Write at 0x00c0012ad0b0 by goroutine 1313:
  runtime.mapassign_faststr()
      /Users/mykhailo_bobrovskyi/go/pkg/mod/golang.org/[email protected]/src/runtime/map_faststr.go:203 +0x41c
  sigs.k8s.io/kueue/pkg/queue.(*ClusterQueue).Delete()
      /Users/mykhailo_bobrovskyi/Projects/epam/kueue/pkg/queue/cluster_queue.go:194 +0x10c
  sigs.k8s.io/kueue/pkg/queue.(*Manager).deleteWorkloadFromQueueAndClusterQueue()
      /Users/mykhailo_bobrovskyi/Projects/epam/kueue/pkg/queue/manager.go:377 +0x1c4
  sigs.k8s.io/kueue/pkg/queue.(*Manager).DeleteWorkload()
      /Users/mykhailo_bobrovskyi/Projects/epam/kueue/pkg/queue/manager.go:365 +0xec
  sigs.k8s.io/kueue/pkg/controller/core.(*WorkloadReconciler).Update()
      /Users/mykhailo_bobrovskyi/Projects/epam/kueue/pkg/controller/core/workload_controller.go:661 +0x1840
  sigs.k8s.io/controller-runtime/pkg/internal/source.(*EventHandler).OnUpdate()
      /Users/mykhailo_bobrovskyi/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/source/event_handler.go:113 +0x49c

Does this PR introduce a user-facing change?

Fix race condition on delete workload from queue manager.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mbobrovskyi]

/test all

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	5fa3f00
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66751b3b7256170008d1e810
😎 Deploy Preview	https://deploy-preview-2460--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alculquicondor]

/lgtm
/approve

Thanks!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 55a12e2bff37cd5f358c8fef42791cebd363ae38

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

I wonder if we can add -race to our integration tests. Maybe that would have caught this.

[mbobrovskyi]

/retest

[mbobrovskyi]

/test pull-kueue-test-multikueue-e2e-main

[mbobrovskyi]

/cherry-pick release-0.7

[k8s-infra-cherrypick-robot]

@mbobrovskyi: new pull request created: #2465

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.