Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DefaultRequeuingBackoffBaseSeconds to 60s. #2251

Merged
merged 1 commit into from
May 21, 2024
Merged

Set DefaultRequeuingBackoffBaseSeconds to 60s. #2251

merged 1 commit into from
May 21, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 21, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Set DefaultRequeuingBackoffBaseSeconds to 60s.

Which issue(s) this PR fixes:

Fixes #2215

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Increased the default value in the `.waitForPodsReady.requeuingStrategy.backoffBaseSeconds` to 60

ACTION REQUIRED: You can configure `.waitForPodsReady.requeuingStrategy.backoffBaseSeconds` as needed.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 21, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2024
@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 47f93e4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/664cdfc98d482100089d44bc
😎 Deploy Preview https://deploy-preview-2251--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 21, 2024
trasc
trasc reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 579036115ecbd8943df592d53aaaa964287581e0

@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 21, 2024 15:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @mwielgus @mimowo

@mbobrovskyi
Copy link
Contributor Author

/assign @mimowo

mimowo
mimowo reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apis/config/v1beta1/configuration_types.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the cleanup/make-backoffBaseSeconds-default-consistent-with-timeout-in-waitForPodsReady branch from 674ffbf to df4705a Compare May 21, 2024 16:19
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mimowo May 21, 2024 16:19
@mimowo
Copy link
Contributor

mimowo commented May 21, 2024

/lgtm
/approve
/assign @alculquicondor @tenzen-y

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e1f54506ae3ef9d3a966ddca1b6e8e879d24c2c3

tenzen-y
tenzen-y reviewed May 21, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update document as well?

@mbobrovskyi
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/make-backoffBaseSeconds-default-consistent-with-timeout-in-waitForPodsReady branch from df4705a to 3e2ef02 Compare May 21, 2024 16:40
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@mbobrovskyi
Copy link
Contributor Author

@tenzen-y Fixed

@mbobrovskyi
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
tenzen-y
tenzen-y reviewed May 21, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update there:

kueue/keps/1282-pods-ready-requeue-strategy/README.md

Lines 240 to 244 in 3e2ef02

Assuming `backoffLimitCount` equals 10, and `baseDelaySeconds` equals 10 (default) the workload is requeued 10 times
after failing to have all pods ready, then the total time awaiting for requeue
will take (neglecting the jitter): `10s+20s+40s +...+7680s=2h 8min`.
Also, considering `.waitForPodsReady.timeout=300s` (default),
the workload will spend `50min` total waiting for pods ready.
?

@tenzen-y
Copy link
Member

/release-note-edit

Increased the default value in the ".waitForPodsReady.requeuingStrategy.backoffBaseSeconds" to 60

@alculquicondor
Copy link
Contributor

/release-note-edit

Increased the default value in the `.waitForPodsReady.requeuingStrategy.backoffBaseSeconds` to 60

ACTION REQUIRED: You can configure `.waitForPodsReady.requeuingStrategy.backoffBaseSeconds` as needed.

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/make-backoffBaseSeconds-default-consistent-with-timeout-in-waitForPodsReady branch from 3e2ef02 to 47f93e4 Compare May 21, 2024 17:54
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2024
@mbobrovskyi
Copy link
Contributor Author

@tenzen-y fixed. Thanks

tenzen-y
tenzen-y reviewed May 21, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 62e2bf064ca1e029d4a08614431e15d58ae0f71b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit a7ca2ac into kubernetes-sigs:main May 21, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 21, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/make-backoffBaseSeconds-default-consistent-with-timeout-in-waitForPodsReady branch May 21, 2024 20:25
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mbobrovskyi @kannon92
Set DefaultRequeuingBackoffBaseSeconds to 60s. (kubernetes-sigs#2251)
c204d22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@trasc trasc Awaiting requested review from trasc

@mwielgus mwielgus Awaiting requested review from mwielgus

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@trasc trasc

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Make backoffBaseSeconds default consistent with timeout in waitForPodsReady
6 participants
@mbobrovskyi @k8s-ci-robot @mimowo @tenzen-y @alculquicondor @trasc