Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backoffBaseSeconds default consistent with timeout in waitForPodsReady #2215

Closed
mwielgus opened this issue May 17, 2024 · 7 comments · Fixed by #2251
Closed

Make backoffBaseSeconds default consistent with timeout in waitForPodsReady #2215

mwielgus opened this issue May 17, 2024 · 7 comments · Fixed by #2251
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mwielgus
Copy link
Contributor

What would you like to be cleaned:

Increase the default for waitForPodsReady to 5-10 minutes.

Why is this needed:

Currently Kueue retries to run a workload almost immediately after it failed to start it for 5 minutes. If the situation was not favorable for the workload for 5 minutes (there was no space in the cluster, cluster autoscaler failed to deliver nodes, the workload is crashing immediately after start etc) it is unlikely to improve just after 10 or 20 seconds.

cc: @tenzen-y @mimowo

@mwielgus mwielgus added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 17, 2024
@tenzen-y
Copy link
Member

SGTM
@mwielgus I'm not familiar with ClusterAutoscaler, so could you tell me about how many minutes does cluster-autoscaler prepare a new Node generally take?

@mwielgus
Copy link
Contributor Author

This depends on the cloud provider. Usually somewhere between 1-3 minutes. Within 5 minutes the nodes should be up and pods running unless there is limited availability of the requested resources.

@alculquicondor
Copy link
Contributor

I would put it to 1 minute and only for v0.7, where it's configurable.

@mimowo
Copy link
Contributor

mimowo commented May 20, 2024

I agree with both suggestions.

  • 0.6: yes, it is not configurable so keeping a lower base (10s as currently) might be more universal
  • 0.7+: I think 1min might be more practical for users and admins who want to observe the timeout in action, say after config change, as waiting 5min in that case might be tedious.

@mimowo
Copy link
Contributor

mimowo commented May 20, 2024

/trasc
EDIT: mistake :)

@mimowo
Copy link
Contributor

mimowo commented May 20, 2024

@trasc

@mbobrovskyi
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants