Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce an on-demand API endpoint for fetching pending workloads in a cluster queue #1251

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Introduce an on-demand API endpoint for fetching pending workloads in a cluster queue #1251

merged 1 commit into from
Nov 23, 2023

Conversation

PBundyra
Copy link
Contributor

@PBundyra PBundyra commented Oct 24, 2023 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Part of the KEP#168-2

Which issue(s) this PR fixes:

Part of #168

Special notes for your reviewer:

In order to test it, create pending workloads and then send requests:
kubectl get --raw /apis/visibility.kueue.x-k8s.io/v1alpha1/clusterqueues/<CQ-NAME>/pendingworkloads

Does this PR introduce a user-facing change?

Visibility API: Introduce an on-demand API endpoint for fetching pending workloads in a ClusterQueue.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit b37c7ab
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/655f1504be05e400086e2aa1

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @PBundyra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 26, 2023
@PBundyra PBundyra force-pushed the cq-visibility branch 2 times, most recently from b68b309 to bb7b586 Compare October 26, 2023 11:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 26, 2023
@PBundyra PBundyra changed the title [WIP] Add ClusterQueue visibility without etcd size limit Add ClusterQueue visibility without etcd size limit Oct 26, 2023
@PBundyra PBundyra marked this pull request as ready for review October 26, 2023 11:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2023
@PBundyra
Copy link
Contributor Author

/assign @mimowo

@PBundyra PBundyra changed the title Add ClusterQueue visibility without etcd size limit [WIP] Add ClusterQueue visibility without etcd size limit Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2023
@mimowo
Copy link
Contributor

mimowo commented Oct 26, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2023
mimowo
mimowo reviewed Oct 26, 2023
View reviewed changes
apis/api_extension/v1alpha1/groupversion_info.go Outdated Show resolved Hide resolved
apis/api_extension/v1alpha1/visibility_types.go Outdated Show resolved Hide resolved
apis/api_extension/v1alpha1/visibility_types.go Outdated Show resolved Hide resolved
charts/kueue/templates/manager/manager.yaml Outdated Show resolved Hide resolved
charts/kueue/templates/manager/manager.yaml Show resolved Hide resolved
config/components/rbac/kustomization.yaml Outdated Show resolved Hide resolved
config/default/kustomization.yaml Outdated Show resolved Hide resolved
hack/update-codegen.sh Outdated Show resolved Hide resolved
pkg/visibility/config.go Outdated Show resolved Hide resolved
apis/api_extension/v1alpha1/visibility_types.go Outdated Show resolved Hide resolved
@PBundyra
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-25

mimowo
mimowo reviewed Oct 30, 2023
View reviewed changes
hack/update-helm.sh Outdated Show resolved Hide resolved
hack/update-helm.sh Show resolved Hide resolved
hack/update-helm.sh Show resolved Hide resolved
pkg/visibility/api/pending_workload_CQ.go Outdated Show resolved Hide resolved
pkg/visibility/api/pending_workload_CQ.go Outdated Show resolved Hide resolved
pkg/visibility/api/pending_workload_CQ.go Outdated Show resolved Hide resolved
pkg/visibility/api/pending_workload_CQ.go Outdated Show resolved Hide resolved
pkg/visibility/api/pending_workload_CQ.go Outdated Show resolved Hide resolved
pkg/visibility/api/pending_workload_CQ.go Outdated Show resolved Hide resolved
@PBundyra PBundyra force-pushed the cq-visibility branch 5 times, most recently from b587b3f to 8e2fad8 Compare November 22, 2023 14:36
mimowo
mimowo reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits to make the e2e test more readable

test/e2e/stash.txt Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/config/manager_e2e_patch.yaml Outdated Show resolved Hide resolved
@mimowo
Copy link
Contributor

mimowo commented Nov 22, 2023

This failure looks related: "https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1251/pull-kueue-test-e2e-main-1-26/1727335355239108608". I suspect this is the issue with the mechanism to evict the sampleJob1.

Maybe we should actually go with the 5s approach as here, and a couple other preexiting tests. Then, we can have a follow up issue to improve execution time of the e2e tests more holistically.

mimowo
mimowo reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. @PBundyra Please squash the commits and mark the addressed comments as resolved.

test/util/util.go Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@PBundyra PBundyra force-pushed the cq-visibility branch 6 times, most recently from f53eb35 to c70071c Compare November 22, 2023 19:00
mimowo
mimowo reviewed Nov 23, 2023
View reviewed changes
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@PBundyra
Add ClusterQueue visibility on-demand
b37c7ab 
    Co-authored-by: Yuki Iwai <[email protected]>

    Co-authored-by: Aldo Culquicondor <[email protected]>

    Co-authored-by: Michał Woźniak <[email protected]>
@mimowo
Copy link
Contributor

mimowo commented Nov 23, 2023

/lgtm
Awesome, thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64097d68b953254803348f3c34794f1e7de49fd5

@mimowo
Copy link
Contributor

mimowo commented Nov 23, 2023

/hold cancel
we have the KEP merged already: #1069

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit ec340f2 into kubernetes-sigs:main Nov 23, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Nov 23, 2023
B1F030 pushed a commit to B1F030/kueue that referenced this pull request Nov 24, 2023
@PBundyra @B1F030
Add ClusterQueue visibility on-demand (kubernetes-sigs#1251)
3532b22 
Co-authored-by: Yuki Iwai <[email protected]>

    Co-authored-by: Aldo Culquicondor <[email protected]>

    Co-authored-by: Michał Woźniak <[email protected]>
@PBundyra PBundyra deleted the cq-visibility branch January 29, 2024 11:27
@alculquicondor
Copy link
Contributor

/release-note-edit

Visibility API: Introduce an on-demand API endpoint for fetching pending workloads in a ClusterQueue.

@PBundyra PBundyra mentioned this pull request Feb 28, 2024
Closed
9 tasks
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@PBundyra @kannon92
Add ClusterQueue visibility on-demand (kubernetes-sigs#1251)
0c41afe 
Co-authored-by: Yuki Iwai <[email protected]>

    Co-authored-by: Aldo Culquicondor <[email protected]>

    Co-authored-by: Michał Woźniak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@mimowo mimowo mimowo left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
6 participants
@PBundyra @k8s-ci-robot @mimowo @alculquicondor @tenzen-y @mwielgus