Skip to content

Commit

Permalink
Fix make generate command
Browse files Browse the repository at this point in the history
  • Loading branch information
PBundyra committed Oct 26, 2023
1 parent d038fdd commit b68b309
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 29 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ update-helm: manifests yq

.PHONY: generate
generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations and client-go libraries.
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./apis/..."
./hack/update-codegen.sh $(GO_CMD)

.PHONY: fmt
Expand Down
16 changes: 0 additions & 16 deletions charts/kueue/templates/rbac/role_binding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,3 @@ subjects:
- kind: ServiceAccount
name: '{{ include "kueue.fullname" . }}-controller-manager'
namespace: '{{ .Release.Namespace }}'
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
labels:
control-plane: controller-manager
name: visibility-server-auth-reader-kube
namespace: kube-system
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: extension-apiserver-authentication-reader
subjects:
- kind: ServiceAccount
name: kueue-controller-manager
namespace: kueue-system
17 changes: 17 additions & 0 deletions charts/kueue/templates/rbac/visibility_viewer_role.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# permissions for end users to view pending workloads.
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: '{{ include "kueue.fullname" . }}-visibility-viewer-role'
labels:
rbac.kueue.x-k8s.io/batch-admin: "true"
rbac.kueue.x-k8s.io/batch-user: "true"
rules:
- apiGroups:
- pending-workloads.kueue.x-k8s.io
resources:
- clusterqueues
verbs:
- get
- list
- watch
13 changes: 1 addition & 12 deletions config/components/visibility/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
resources:
- apiservice.yaml
- role_binding.yaml
- service.yaml

patches:
- target:
kind: RoleBinding
name: visibility-server-auth-reader
patch: |-
- op: replace
path: /metadata/namespace
value: kube-system
- service.yaml

0 comments on commit b68b309

Please sign in to comment.