Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect download failures when status code > 200 #820

Merged
merged 1 commit into from
Jul 13, 2023
Merged

detect download failures when status code > 200 #820

merged 1 commit into from
Jul 13, 2023

Conversation

daniel-garcia
Copy link
Contributor

@daniel-garcia daniel-garcia commented Feb 20, 2023 •
edited
Loading

detect download failures when status code is > 200
#819

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @daniel-garcia!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2023
@daniel-garcia daniel-garcia force-pushed the detectBadStatuscode branch 2 times, most recently from 487f747 to 1ed8070 Compare February 20, 2023 08:19
@daniel-garcia daniel-garcia changed the title fixes #819: detect download failures when status code is >= 400 detect download failures when status code is >= 400 Feb 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 20, 2023
@daniel-garcia daniel-garcia mentioned this pull request Feb 26, 2023
Closed
@daniel-garcia daniel-garcia changed the title detect download failures when status code is >= 400 detect download failures when status code > 200 Feb 26, 2023
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2023
@ahmetb
Copy link
Member

ahmetb commented May 15, 2023

Thanks for this patch, sorry it didn't catch my attention earlier. Can we also add a test case (with a httptest server responding with 404 ) to validate this doesn't regress?

@daniel-garcia daniel-garcia force-pushed the detectBadStatuscode branch from 329d689 to 5a65f69 Compare May 21, 2023 03:38
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2023
@daniel-garcia daniel-garcia force-pushed the detectBadStatuscode branch from 5a65f69 to 6a7d16f Compare May 21, 2023 03:41
@daniel-garcia
Copy link
Contributor Author

Thanks for this patch, sorry it didn't catch my attention earlier. Can we also add a test case (with a httptest server responding with 404 ) to validate this doesn't regress?

done.

@daniel-garcia daniel-garcia force-pushed the detectBadStatuscode branch from 6a7d16f to 156876c Compare May 21, 2023 04:50
@daniel-garcia daniel-garcia force-pushed the detectBadStatuscode branch from 156876c to 15c40b6 Compare May 21, 2023 05:17
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2023
@ankishagarwal
Copy link

Can we complete this if all okay ? We need this change, thank you

@ahmetb
Copy link
Member

ahmetb commented Jul 13, 2023

/lgtm

thanks.

@ahmetb
Copy link
Member

ahmetb commented Jul 13, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ankishagarwal, daniel-garcia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@ahmetb
Copy link
Member

ahmetb commented Jul 13, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 48716ed into kubernetes-sigs:master Jul 13, 2023
@daniel-garcia daniel-garcia deleted the detectBadStatuscode branch September 24, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankishagarwal ankishagarwal ankishagarwal approved these changes

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@ahmetb ahmetb

@stmcginnis stmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daniel-garcia @k8s-ci-robot @stmcginnis @ahmetb @ankishagarwal