Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download failures are interpreted as checksum mismatch #819

Closed
daniel-garcia opened this issue Feb 20, 2023 · 4 comments
Closed

download failures are interpreted as checksum mismatch #819

daniel-garcia opened this issue Feb 20, 2023 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@daniel-garcia
Copy link
Contributor

The krew client ignores the status code. This results in misleading errors that show a checksum mismatch when in fact the artifact was never downloaded. According to the go documentation:

A non-2xx response doesn't cause an error

daniel-garcia added a commit to daniel-garcia/krew that referenced this issue Feb 20, 2023
daniel-garcia added a commit to daniel-garcia/krew that referenced this issue Feb 20, 2023
@daniel-garcia daniel-garcia changed the title detect download failures when status code > 400 download failures are interpreted as checksum mismatch Feb 20, 2023
@ahmetb
Copy link
Member

ahmetb commented Feb 24, 2023

Agreed. Feel free to send a PR. I think we can check for non-200 codes as we expect the client to follow redirects and eventually hit an HTTP 200 OK.

@daniel-garcia
Copy link
Contributor Author

I have a pr here #820

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants