Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v0.5.0 of reliably #1083

Merged

Conversation

mperrien
Copy link
Contributor

@mperrien mperrien commented Mar 3, 2021

hey krew-index team,

I would like to open this PR to publish version v0.5.0 of Reliably.

Thanks,
Marc

Signed-off-by: Marc Perrien [email protected]

@ahmetb
Copy link
Member

ahmetb commented Mar 3, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/reliably.yaml is not a straightforward version bump: changing old version ("0.3.0") with new version ("0.5.0") in the url (https://github.com/reliablyhq/cli/releases/download/v0.3.0/reliably_v0.3.0_darwin_amd64.tar.gz) does not appear in the patch as https://github.com/reliablyhq/cli/releases/download/v0.5.0/reliably_v0.5.0_darwin_amd64.tar.gz

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2021
@mperrien
Copy link
Contributor Author

mperrien commented Mar 3, 2021

Hello,

This wasn't submitted by krew-release-bot because of the issue mentioned a few days ago [1].

Also, it looks like it won't automatically merge because we changed our URLs. Sorry about that!

Marc

[1] #1078

@ahmetb
Copy link
Member

ahmetb commented Mar 3, 2021

Your manifest isn't installing correctly. See error logs.

@ahmetb
Copy link
Member

ahmetb commented Mar 4, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/reliably.yaml is not a straightforward version bump: changing old version ("0.3.0") with new version ("0.5.0") in the url (https://github.com/reliablyhq/cli/releases/download/v0.3.0/reliably_v0.3.0_darwin_amd64.tar.gz) does not appear in the patch as https://github.com/reliablyhq/cli/releases/download/v0.5.0/reliably_v0.5.0_darwin_amd64.tar.gz

@mperrien
Copy link
Contributor Author

mperrien commented Mar 4, 2021

🤦‍♂️
Fixed...

@corneliusweig
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig, mperrien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit f9b5e27 into kubernetes-sigs:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants