Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reliably plugin homepage #1078

Closed

Conversation

mperrien
Copy link
Contributor

@mperrien mperrien commented Mar 1, 2021

This PR aims to update the Reliably plugin homepage in the manifest and change it to https://github.com/reliablyhq/cli

The current homepage (https://reliably.com/docs) prevents us from using Krew Release Bot.

Before submitting a PR, Krew Release Bot identifies the owner of the plugin by comparing the homepage in the manifest with the GitHub user of the repo in which it is run. [1]

Putting https://reliably.com/docs as the homepage was a suggestion by Ahmet [2], but I'm updating the CLI README so it makes better reference to the CLI usage as a Krew plugin.

[1] https://github.com/rajatjindal/krew-release-bot/blob/0846c787e0279b71f45d94c5b2c8e4cddb59afe9/pkg/krew/validations.go#L23
[2] #1022 (comment)

Signed-off-by: Marc Perrien [email protected]

@ahmetb
Copy link
Member

ahmetb commented Mar 1, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/reliably.yaml is not a straightforward version bump: could not find the old/new version spec in the diff

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mperrien
To complete the pull request process, please assign ahmetb after the PR has been reviewed.
You can assign the PR to them by writing /assign @ahmetb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2021
@ahmetb
Copy link
Member

ahmetb commented Mar 1, 2021

@rajatjindal
Copy link
Contributor

rajatjindal commented Mar 1, 2021 via email

@rajatjindal
Copy link
Contributor

I've removed the validation from krew-release-bot along with some minor improvements. please use version v0.0.39 that.

@mperrien
Copy link
Contributor Author

mperrien commented Mar 5, 2021

Thank you @rajatjindal! And thanks @ahmetb too.

I'm closing this PR.

@mperrien mperrien closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants