-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Reliably plugin homepage #1078
Conversation
Signed-off-by: Marc Perrien <[email protected]>
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 This pull request does not seem to be a straightforward version bump. I'll have a human review this. Why wasn't this detected as a plugin version bump:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mperrien The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think the right fix is to remove https://github.com/rajatjindal/krew-release-bot/blob/0846c787e0279b71f45d94c5b2c8e4cddb59afe9/pkg/krew/validations.go#L23-L25 @rajatjindal do you recall why do we have that check? |
I think it was added to make sure no one else can trigger the github
actions to release the plugin they dont own
But given that we dont auto-merge if its not just version change, i think
we can remove that validation from krew release bot
I will make change and cut a new release as soon as i am on my laptop
On Mon, Mar 1, 2021 at 9:07 PM Ahmet Alp Balkan ***@***.***> wrote:
I think the right fix is to remove
https://github.com/rajatjindal/krew-release-bot/blob/0846c787e0279b71f45d94c5b2c8e4cddb59afe9/pkg/krew/validations.go#L23-L25
@rajatjindal <https://github.com/rajatjindal> do you recall why do we
have that check?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1078 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEVN7FKIPQY3ZZY2LUGBOLTBOYCXANCNFSM4YMVPF6Q>
.
--
Rajat Jindal | Pune | https://rajatjindal.com | [email protected]
|
I've removed the validation from krew-release-bot along with some minor improvements. please use version v0.0.39 that. |
Thank you @rajatjindal! And thanks @ahmetb too. I'm closing this PR. |
This PR aims to update the Reliably plugin homepage in the manifest and change it to https://github.com/reliablyhq/cli
The current homepage (https://reliably.com/docs) prevents us from using Krew Release Bot.
Before submitting a PR, Krew Release Bot identifies the owner of the plugin by comparing the homepage in the manifest with the GitHub user of the repo in which it is run. [1]
Putting https://reliably.com/docs as the homepage was a suggestion by Ahmet [2], but I'm updating the CLI README so it makes better reference to the CLI usage as a Krew plugin.
[1] https://github.com/rajatjindal/krew-release-bot/blob/0846c787e0279b71f45d94c5b2c8e4cddb59afe9/pkg/krew/validations.go#L23
[2] #1022 (comment)
Signed-off-by: Marc Perrien [email protected]