-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: match LabelDomainExceptions correctly as label domains #808
fix: match LabelDomainExceptions correctly as label domains #808
Conversation
Pull Request Test Coverage Report for Build 6942718573Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Looks like CI is failing. I think you need to run |
I missed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
f0eedb8
to
2e9f7ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
Match
node-restriction.kubernetes.io
as the label domain instead of the exact match.& make the GetLabelDomain function public to be re-used in Karpenter launchtemplate.go which should remove
[*].node-restriction.kubernetes.io
from user-data.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.