fix: match LabelDomainExceptions correctly as label domains #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
splichy
changed the title
jonathan-innis
force-pushed
the
node_restriction_label_ns
branch
from
e5e11f2
to
4e944ca
Compare
jonathan-innis
force-pushed
the
node_restriction_label_ns
branch
from
ef6c014
to
f26d0cd
Compare
|
Snapshot successfully published to |
jonathan-innis
added a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Jonathan Innis <[email protected]>
jonathan-innis
added a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Jonathan Innis <[email protected]>
jonathan-innis
added a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Jonathan Innis <[email protected]>
johngmyers
pushed a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
Co-authored-by: Jonathan Innis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Match
node-restriction.kubernetes.ioas the label domain instead of the exact match.update launchtemplate.go to remove
[*].node-restriction.kubernetes.iofrom user-data - now it matches only labels that start withnode-restriction.kubernetes.io.Requires: kubernetes-sigs/karpenter#808
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.