Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup YAML formatting #1328

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Cleanup YAML formatting #1328

merged 1 commit into from
Nov 1, 2023

Conversation

FaithKovi
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1313

Additional context
Add any other context for the reviewers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @FaithKovi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2023
@FaithKovi FaithKovi mentioned this pull request Oct 20, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@mboersma
Copy link
Contributor

Thanks @FaithKovi! This looks much better.

Apparently there's a conflict with #1324 that just merged. Could you rebase the PR from the current main branch and force-push it? Sorry for the hassle!

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2023
@mboersma
Copy link
Contributor

/ok-to-test

@FaithKovi I rebased this off main–I hope that's ok with you. I can take a look at fixing up the newlines today as well, and hopefully it's ready to merge after that.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2023
@mboersma mboersma removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2023
@mboersma
Copy link
Contributor

/assign @AverageMarcus @drew-viles

AverageMarcus
AverageMarcus reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just want to double check those backslashes are correct.

images/capi/ansible/windows/roles/cloudbase-init/tasks/main.yml
@@ -15,33 +15,33 @@
- name: Download Cloudbase-init
win_get_url:
url: "{{ cloudbase_init_url }}"
dest: '{{ tempdir.stdout | trim }}\CloudbaseInitSetup.msi'
dest: "{{ tempdir.stdout | trim }}\\CloudbaseInitSetup.msi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check, are these backslashes supposed to be escaped? I would have expected them to also need to be with the quotes.

Copy link
Contributor

@mboersma mboersma Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these backslashes supposed to be escaped?

Evidently single quotes work differently from double quotes in ansible. The best guidance on Windows paths in ansible I've found is here.

# GOOD
tempdir: C:\Windows\Temp

# WORKS
tempdir: 'C:\Windows\Temp'
tempdir: "C:\\Windows\\Temp"

# BAD, BUT SOMETIMES WORKS
tempdir: C:\\Windows\\Temp
tempdir: 'C:\\Windows\\Temp'
tempdir: C:/Windows/Temp

I'm not sure why ansible-lint fix prefers that variant, but it works.

See also #767.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@AverageMarcus
Copy link
Member

Thank you so much for being so patient with this @FaithKovi

drew-viles
drew-viles approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@drew-viles drew-viles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @FaithKovi !!

@AverageMarcus
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7cb76c7 into kubernetes-sigs:main Nov 1, 2023
9 checks passed
@drew-viles drew-viles mentioned this pull request Feb 27, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus AverageMarcus left review comments

@drew-viles drew-viles drew-viles approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@drew-viles drew-viles

@AverageMarcus AverageMarcus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML formatting should be cleaned up to linter standards
5 participants
@FaithKovi @k8s-ci-robot @mboersma @AverageMarcus @drew-viles