Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tasks to install runsc for gvisor integration #1324

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add tasks to install runsc for gvisor integration #1324

merged 1 commit into from
Oct 19, 2023

Conversation

heytrav
Copy link

@heytrav heytrav commented Oct 16, 2023

What this PR does / why we need it:

This PR adds the option to install runsc, making it possible to create sandboxed pods using gvisor.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

This PR does not fix any known issues.

Additional context
The Ansible tasks implement the installation instructions on the gVisor website. To run them the flag containerd_gvisor_runtime must be set to true.

Then the user must create a RuntimeClass and use it as described in the containerd RuntimeClasses documentation

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @heytrav. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2023
mboersma
mboersma reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2023
@mboersma
Copy link
Contributor

To run them the flag containerd_gvisor_runtime must be set to true.
Then the user must create a RuntimeClass and use it

Should we (briefly) document these steps somewhere in image-builder itself?

@heytrav
Copy link
Author

heytrav commented Oct 16, 2023

To run them the flag containerd_gvisor_runtime must be set to true.
Then the user must create a RuntimeClass and use it

Should we (briefly) document these steps somewhere in image-builder itself?

Yes I think that would be helpful. I'll have a look and see where I can add something but I'm happy to add it wherever the preferred location is.

@mboersma
Copy link
Contributor

wherever the preferred location is.

I looked at the Image Builder book and I think we could either add something to the main page or create a new topic like "Customizing containerd".

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2023
@heytrav heytrav force-pushed the gvisor-integration branch 4 times, most recently from 27d3a1d to 446d7b9 Compare October 17, 2023 05:57
mboersma
mboersma reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @AverageMarcus

The docs you added are 💯, thanks so much!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
AverageMarcus
AverageMarcus reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @heytrav!

Just a couple very small comments I'm not sure of. 😄

images/capi/ansible/roles/containerd/tasks/main.yml Outdated Show resolved Hide resolved
docs/book/src/capi/containerd/customizing-containerd.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@AverageMarcus
Copy link
Member

Thanks for those updates. Looks great! Would you mind squashing your commits before we merge in please?

Add tasks to install runsc for gvisor integration
aed2a1e 
* Add changed_when conditions
* Add docs
* packer arguments
@AverageMarcus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 478379d into kubernetes-sigs:main Oct 19, 2023
13 checks passed
@mboersma mboersma mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus AverageMarcus left review comments

@mboersma mboersma mboersma left review comments

@kkeshavamurthy kkeshavamurthy Awaiting requested review from kkeshavamurthy

Assignees

@mboersma mboersma

@AverageMarcus AverageMarcus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heytrav @k8s-ci-robot @mboersma @AverageMarcus