Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix netword-dispatcher url for Photon builds #1121

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix netword-dispatcher url for Photon builds #1121

merged 1 commit into from
Apr 4, 2023

Conversation

SanikaGawhane
Copy link
Member

What this PR does / why we need it:
Install networkd-dispatcher service (Download from source)] that downloads the source file is incorrectly unarchiving the .bz2 file. Hence the next ansible task fails since it can't find the files -
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_image-builder/1120/pull-ova-all/1641194226899226624/artifacts/photon-3.log

Changing the download source to .gz fixes this issue.

/assign @kkeshavamurthy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2023
@SanikaGawhane
Copy link
Member Author

/test pull-ova-all

1 similar comment
@SanikaGawhane
Copy link
Member Author

/test pull-ova-all

@kkeshavamurthy
Copy link
Member

Thanks for the fix @SanikaGawhane
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
This was referenced Mar 30, 2023
Merged
Merged
@kkeshavamurthy
Copy link
Member

@jsturtevant @mboersma
are you guys able to approve this? Seems like something is messed up.

mboersma
mboersma approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mboersma
Copy link
Contributor

/approve

@mboersma
Copy link
Contributor

/approve cancel

@mboersma
Copy link
Contributor

mboersma commented Mar 31, 2023 •
edited
Loading

/approve

Edit: I wonder if it's just this PR having the approval problem.

@nawazkh
Copy link
Member

nawazkh commented Apr 3, 2023

@CecileRobertMichon @jsturtevant Looks like this PR is having approval problems?
Shall we wait for Matt on this or can this be approved? I am not sure.

@CecileRobertMichon
Copy link
Contributor

I no longer have approve powers in this repo. @kkeshavamurthy are you able to try again?

If not @SanikaGawhane you might need to close this PR and open a new one since it seems stuck

@jsturtevant
Copy link
Contributor

/approve

1 similar comment
@kkeshavamurthy
Copy link
Member

/approve

@kkeshavamurthy
Copy link
Member

kkeshavamurthy commented Apr 3, 2023 •
edited
Loading

Does not seem to be working. I tried approving #1124 and did not work there as well. So, reopening the PR might not be enough.

@jsturtevant
Copy link
Contributor

seems like something is mixed up with prow, might need to start a thread in the #sig-k8s-infra or #testing-ops

@nawazkh
Copy link
Member

nawazkh commented Apr 3, 2023

Raised the concern on https://kubernetes.slack.com/archives/C7J9RP96G/p1680561517389429
Thanks @jsturtevant for pointing out the channel!

@TerryHowe
Copy link
Member

Raised the concern on https://kubernetes.slack.com/archives/C7J9RP96G/p1680561517389429 Thanks @jsturtevant for pointing out the channel!

Probably #1126 will fix

@abhay-krishna
Copy link
Contributor

@mboersma Can we get this merged? Some presubmits on other PRs need this change to pass. Thanks!

@nawazkh
Copy link
Member

nawazkh commented Apr 4, 2023

@mboersma Can we get this merged? Some presubmits on other PRs need this change to pass. Thanks!

@mboersma is out on vacation. Can @CecileRobertMichon @jsturtevant please take a look at this?

@jsturtevant
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, kkeshavamurthy, mboersma, SanikaGawhane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@jsturtevant
Copy link
Contributor

/test pull-ova-all

@jsturtevant
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 28c38c3 into kubernetes-sigs:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

Assignees

@kkeshavamurthy kkeshavamurthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@SanikaGawhane @kkeshavamurthy @mboersma @nawazkh @CecileRobertMichon @jsturtevant @TerryHowe @abhay-krishna @k8s-ci-robot