Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RHEL 8 RAW image builds #1120

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Add support for RHEL 8 RAW image builds #1120

merged 1 commit into from
Apr 5, 2023

Conversation

abhay-krishna
Copy link
Contributor

Adding support for RHEL 8 RAW image builds.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @abhay-krishna. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 28, 2023
@abhay-krishna
Add support for RHEL 8 RAW image builds
e5e4a87 
Signed-off-by: Abhay Krishna Arunachalam <[email protected]>
@abhay-krishna abhay-krishna mentioned this pull request Mar 29, 2023
Closed
9 tasks
@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 29, 2023
@abhay-krishna
Copy link
Contributor Author

/retest

1 similar comment
@abhay-krishna
Copy link
Contributor Author

/retest

@abhay-krishna
Copy link
Contributor Author

@mboersma is the pull-ova-all presubmit being flaky? It fails on photon-3, photon-4, centos-7, I checked the logs in the artifacts directory but they don't seem to be related to my changes.

@abhay-krishna
Copy link
Contributor Author

/retest

@kkeshavamurthy
Copy link
Member

/lgtm
@SanikaGawhane Is looking into the photon failures. Ubuntu seems like a flake.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2023
@SanikaGawhane
Copy link
Member

/test pull-ova-all

@abhay-krishna
Copy link
Contributor Author

/retest

@kkeshavamurthy
Copy link
Member

@abhay-krishna
#1121 should fix the photon ci failures. Please rebase.

@abhay-krishna
Copy link
Contributor Author

abhay-krishna commented Mar 30, 2023 •
edited
Loading

@abhay-krishna #1121 should fix the photon ci failures. Please rebase.

Thanks @kkeshavamurthy! Seems like that PR didn't get an approved label. Will rebase after that gets merged.

@abhay-krishna
Copy link
Contributor Author

/retest

@kkeshavamurthy
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, kkeshavamurthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@abhay-krishna
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@abhay-krishna: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ova-all e5e4a87 link unknown /test pull-ova-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhay-krishna
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit e49431f into kubernetes-sigs:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kkeshavamurthy kkeshavamurthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhay-krishna @k8s-ci-robot @mboersma @kkeshavamurthy @SanikaGawhane