Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HNC to propagate changes to CRD. #59

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Allow HNC to propagate changes to CRD. #59

merged 1 commit into from
Jul 16, 2021

Conversation

just1900
Copy link
Contributor

@just1900 just1900 commented Jul 9, 2021

Fix #53
Currently, HNC are clearing out most of the metadata when doing an update request, which works fine for most types, but fails for CRDs. This PR allows HNC to propagate changes to CRD by setting 'ResourceVersion' explicitly when performing an update.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @just1900!

It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @just1900. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2021
@just1900 just1900 mentioned this pull request Jul 9, 2021
Closed
@adrianludwin
Copy link
Contributor

NB: this is a continuation of kubernetes-retired/multi-tenancy#1513

adrianludwin
adrianludwin reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after one tiny last change. @rjbez17 , lgty?

/ok-to-test

test/e2e/issues_test.go Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2021
@adrianludwin
Copy link
Contributor

adrianludwin commented Jul 9, 2021 via email

@just1900 just1900 requested a review from adrianludwin July 10, 2021 02:09
@adrianludwin
Copy link
Contributor

Sorry can you please squash those two commits?

@just1900
Allow HNC to propagate changes to CRD.
5b9e3cb 
Currently, HNC are clearing out most of the metadata when doing an update request, which works fine for most types, but fails for CRDs. This PR allows HNC to propagate changes to CRD by setting 'ResourceVersion' explicitly when performing an update.
Tested: before this change, the added e2etest case will fail, another way to reproduce is, first create an crd in the parent namespace, and then update whatever field of the crd, wait a second and run the following command:
kubectl hns describe child

Result:

Events from the objects in namespace child
Last Seen Reason             Object                     Message
0s        CannotUpdateObject EETest:child/eetest-sample Could not write from source namespace parent: eetests.e2e.hnc.x-k8s.io eetest-sample is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update.

After this change, you should see it propagates normally and the inherited crd's field is updated.
adrianludwin
adrianludwin reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
/assign @rjbez17

Ryan, lgty?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 12, 2021
@just1900
Copy link
Contributor Author

sry, Fetch and Merge button is triggered on this branch by accident, I've force pushed, nothing have changed.

adrianludwin
adrianludwin reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@rjbez17 lmk if you had any concerns with this one, but I think it's ready to merge

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, just1900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 291134a into kubernetes-sigs:master Jul 16, 2021
@adrianludwin adrianludwin added this to the release-v0.9 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianludwin adrianludwin adrianludwin left review comments

@rjbez17 rjbez17 Awaiting requested review from rjbez17

Assignees

@rjbez17 rjbez17

@adrianludwin adrianludwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
release-v0.9
Development

Successfully merging this pull request may close these issues.

Unable to update propagated CRD object
4 participants
@just1900 @k8s-ci-robot @adrianludwin @rjbez17