Allow HNC to propagate changes to CRD.

[just1900]

A PR would be great, thanks! Just a few quick pointers / requests:

• A change like this benefits from a lot of comments, e.g. linking to this issue. Otherwise we'll have no idea why we added this in a few months.

• It would be great if you could add or update a unit test to verify that the rV is being copied (e.g. here.

• It would be amazing if you could update an end-to-end test (e.g. here) to try to propagate a CRD, show that this fails without your fix, and that it passes with your fix. This test is probably a pretty good model, and you can embed yaml in the test as shown here.

  • The e2e tests assume that you've deployed HNC to a cluster, and your kubectl config is currently pointing at the cluster you want to run the tests on.
  • Running all the e2e tests takes ~30min but you only need to run the one you're writing. So you can modify your test so that the It() function has an F (for "focus") in front of it, like this: FIt() (note the first two letters are capitalized). This will only run your test. Just remember to change it back to It() before you submit the PR.

• We use one commit per PR so please squash all commits and force-update the PR branch if necessary. We also describe how we tested the change in the commit message like this.

@adrianludwin PTAL, follow your pointers

• I have link the issue and add some description to the code
• for the unit test, I have no idea about how to verify that the rV is being copied by now, because every resource in k8s will have a ResourceVersion.
• e2e test have been added and tested.
• the commit msg is detailed for how to reproduce before this pr's change.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @just1900!

It looks like this is your first PR to kubernetes-sigs/multi-tenancy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/multi-tenancy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @just1900. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: just1900
To complete the pull request process, please assign adrianludwin after the PR has been reviewed.
You can assign the PR to them by writing /assign @adrianludwin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[just1900]

I signed it

[adrianludwin]

Great change! I've just left a few minor comments.

for the unit test, I have no idea about how to verify that the rV is being copied by now, because every resource in k8s will have a ResourceVersion.

I think that's fine, the e2e test captures everything we need and it's really the interaction with K8s that's important. There might have been a way to test this in the unit tests (which actually run a copy of the apiserver) but in this case, I like the clarity of the e2e test using kubectl.

e2e test have been added and tested.

Thanks for doing that. Can you just confirm that you tested that this new test fails if you break the code, i.e. leave resourceVersion as zero? That might be nice to put into the commit message as well, given that I've asked for some other minor changes anyway.

Also cc @rjbez17 for his review.

[adrianludwin]

Oh man, I just realized this is in the wrong repo! Sorry I didn't pick up on that. Can you please make this change in https://github.com/kubernetes-sigs/hierarchical-namespaces instead? Sorry about that. The code hasn't changed very much (apart from the paths - the incubator/hnc prefix has been removed) so it should be fairly easy to recreate the change in the new repo. I'm really sorry I missed that.

[just1900]

I didn't realize that either 😂, I've open another PR there kubernetes-sigs/hierarchical-namespaces#59.
Shall we close this one?

[adrianludwin]

Yup! Closing this copy.

/close

[k8s-ci-robot]

@adrianludwin: Closed this PR.

In response to this:

Yup! Closing this copy.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.