Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admission webhook validation for Path based on path type #894

Merged
merged 9 commits into from
Oct 6, 2021

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Oct 4, 2021

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change?:

 * HTTP Path match values are validated for PathMatchExact, PathMatchPrefix type

What this PR does / why we need it:
Webhook validatation of HTTPPathMatch.Value for Exact and Prefix Type

Which issue(s) this PR fixes:

Fixes #
Issue #873

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ccfishk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2021
@youngnick
Copy link
Contributor

This LGTM once the other comments are done.

@robscott
Copy link
Member

robscott commented Oct 6, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2021
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 6, 2021
@robscott
Copy link
Member

robscott commented Oct 6, 2021

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccfishk, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit d4d30b0 into kubernetes-sigs:master Oct 6, 2021
@ccfishk ccfishk deleted the validatepath branch October 6, 2021 17:13
youngnick pushed a commit to youngnick/gateway-api that referenced this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants