Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for v1alpha2-rc2 #891

Merged
merged 5 commits into from
Oct 12, 2021

Conversation

youngnick
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Updates the changelog for v1alpha2-rc2 release.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @youngnick! Just a couple non-blocking nits.

/lgtm
/hold

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2021
@robscott
Copy link
Member

robscott commented Oct 4, 2021

For sig-network review and approval:

/cc @danwinship @khenidak @thockin

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
Copy link
Contributor

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is an exciting release.

We should consider folding the RC entities within the changelog to a single 0.3.0, 0.4.0 entries. The end users don't really care about rc releases after a final GA and it is more burdensome for them to parse the changelog in this format.

CHANGELOG.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@youngnick
Copy link
Contributor Author

We should consider folding the RC entities within the changelog to a single 0.3.0, 0.4.0 entries. The end users don't really care about rc releases after a final GA and it is more burdensome for them to parse the changelog in this format.

I was thinking that I'll do this once we are releasing 0.4.0 final. That way, until we do that, there's some versioning info available for implementors.

@khenidak
Copy link

khenidak commented Oct 6, 2021

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2021
Nick Young added 4 commits October 6, 2021 23:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2021
@robscott
Copy link
Member

robscott commented Oct 7, 2021

Thanks for adding in #894 @youngnick! Both @andrewsykim and @danwinship have given the all clear to release without waiting for final rounds of review from them. Once we have an LGTM from @thockin I think we'll be good to go.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2021
@thockin
Copy link

thockin commented Oct 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
CHANGELOG.md Show resolved Hide resolved
@robscott
Copy link
Member

Thanks @youngnick!

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit fd57e3a into kubernetes-sigs:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants