-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md for v1alpha2-rc2 #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this @youngnick! Just a couple non-blocking nits.
/lgtm
/hold
For sig-network review and approval: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is an exciting release.
We should consider folding the RC entities within the changelog to a single 0.3.0
, 0.4.0
entries. The end users don't really care about rc releases after a final GA and it is more burdensome for them to parse the changelog in this format.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbagdi, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I was thinking that I'll do this once we are releasing 0.4.0 final. That way, until we do that, there's some versioning info available for implementors. |
/lgtm Thanks |
Signed-off-by: Nick Young <[email protected]>
Signed-off-by: Nick Young <[email protected]>
Signed-off-by: Nick Young <[email protected]>
Signed-off-by: Nick Young <[email protected]>
720ae28
to
f848730
Compare
Thanks for adding in #894 @youngnick! Both @andrewsykim and @danwinship have given the all clear to release without waiting for final rounds of review from them. Once we have an LGTM from @thockin I think we'll be good to go. /lgtm |
/lgtm |
Signed-off-by: Nick Young <[email protected]>
Thanks @youngnick! /lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updates the changelog for v1alpha2-rc2 release.