Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple Hostnames defined in annotation #197

Closed
jrnt30 opened this issue May 5, 2017 · 7 comments
Closed

Support for multiple Hostnames defined in annotation #197

jrnt30 opened this issue May 5, 2017 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Comments

@jrnt30
Copy link
Contributor

jrnt30 commented May 5, 2017

As an enhancement it would be nice to support having multiple hostnames defined in the annotation for services similar to the KOPS DNS controller.

Example:
external-dns.alpha.kubernetes.io/hostname: "redis.dev.vpn,elasticsearch.dev.vpn"

Use Case:
This might be somewhat of a unique case, but we are attempting to create an NGinx ingress controller resource that can handle multiple services simultaneously.

One limitation we have found with the NGinx Ingress Controller is that for TCP and UDP proxying you have to use a configmap to register the port -> <namespace>/<service>:<containerPort> mapping for the Nginx controller to read.

What this has resulted in is that the NGinx Controller's service (which is the ELB) actually should be "responsible" for defining via the annotation all of the services that are mapped in this way, since there is no explicit Service or Ingress resource.

@jrnt30 jrnt30 changed the title Support for multiple DNS entries in annotation Support for multiple Hostnames defined in annotation May 5, 2017
@hjacobs
Copy link
Contributor

hjacobs commented May 6, 2017

@jrnt30 sounds reasonable. External DNS should eventually replace the KOPS DNS controller, so it makes sense to support the same feature set.

@linki
Copy link
Member

linki commented May 8, 2017

Sounds good to me.

Does anyone have alternative ideas on the spec? A comma-separated list seems fine as DNS names don't include commas, I guess.

@jrnt30 Do you want to tackle this yourself?

@jrnt30
Copy link
Contributor Author

jrnt30 commented May 8, 2017 via email

@mtanski
Copy link

mtanski commented May 16, 2017

route53-kubernetes supports multiple hostnames so this will be needed for compatibility with it (since it's planned)

@linki
Copy link
Member

linki commented May 17, 2017

@mtanski Didn't know. Thanks for telling us.

@ideahitme
Copy link

@jrnt30 are you available to implement this ?

@ideahitme
Copy link

addressed in #256

@jrnt30 jrnt30 marked this as a duplicate of #277 Jul 14, 2017
@linki linki added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/medium labels Jan 2, 2018
lou-lan pushed a commit to lou-lan/external-dns that referenced this issue May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

5 participants