Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Endpoint to have multiple Targets #239

Closed
linki opened this issue Jun 12, 2017 · 3 comments
Closed

Extend Endpoint to have multiple Targets #239

linki opened this issue Jun 12, 2017 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Comments

@linki
Copy link
Member

linki commented Jun 12, 2017

The Endpoint struct is intended to act as an abstraction over plain DNS records (and Ownership records).

We though it makes sense to group (DNSName, IP) pairs by the DNSName, so that Endpoints look like: (DNSName, [IP_1, IP_2, ...]) with a unique DNSName per Endpoint list.

This would make it easy to work on records related to the same domain name, e.g.

  • when using NodePort services with multiple nodes as targets
  • when doing any kind of weighting or canary stuff in the future

This issue is for the groundwork that changes Endpoint from having a Target string to Targets []string

Turned out to be more involved than though, work in progress: https://github.com/linki/external-dns/tree/feat/multiple-targets2

@linki linki added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. size/large labels Jun 12, 2017
@jrnt30
Copy link
Contributor

jrnt30 commented Jun 27, 2017

While revisiting this API, it would be good to integrate #197 there as well. I've looked at starting that a few times and get a bit sucked into the size of the refactor around the changes.

@linki linki added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/large labels Jan 2, 2018
@grimmy
Copy link
Contributor

grimmy commented May 15, 2018

Since pr 493 was merged, I assume this can be closed?

@linki
Copy link
Member Author

linki commented Jun 14, 2018

Yes, it can :)

@linki linki closed this as completed Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

3 participants