Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠ get rid of obsolete Go build tags // +build !ignore_autogenerated #828

Merged
merged 1 commit into from
Jul 14, 2023
Merged

⚠ get rid of obsolete Go build tags // +build !ignore_autogenerated #828

merged 1 commit into from
Jul 14, 2023

Conversation

programmer04
Copy link
Contributor

closes #826

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @programmer04!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @programmer04. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 23, 2023
@sbueringer
Copy link
Member

/test pull-controller-tools-test-master

@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: programmer04, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit dba4afa into kubernetes-sigs:master Jul 14, 2023
@programmer04 programmer04 deleted the rm-build-tags branch July 14, 2023 07:31
LanceEa pushed a commit to emissary-ingress/emissary that referenced this pull request Sep 20, 2023
deps: bump controller-tools to latest release
ed322c7 
Two notable changes occurred with the generated
deep copy code:

1. Removed obsolete build tags
    - kubernetes-sigs/controller-tools#828

2. Fix implicit for loop aliasing
    - kubernetes-sigs/controller-tools#810

Signed-off-by: Lance Austin <[email protected]>
@LanceEa LanceEa mentioned this pull request Sep 20, 2023
Merged
6 tasks
LanceEa pushed a commit to emissary-ingress/emissary that referenced this pull request Sep 20, 2023
@LanceEa
deps: bump controller-tools to latest release
da9b271 
Two notable changes occurred with the generated
deep copy code:

1. Removed obsolete build tags
    - kubernetes-sigs/controller-tools#828

2. Fix implicit for loop aliasing
    - kubernetes-sigs/controller-tools#810

Signed-off-by: Lance Austin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not generate obsolete build tags // +build
3 participants
@programmer04 @k8s-ci-robot @sbueringer