deps: bump controller-runtime and controller-tools to latest #5310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2023 06:43
Signed-off-by: Lance Austin <[email protected]>
Two notable changes occurred with the generated
deep copy code:
1. Removed obsolete build tags
- kubernetes-sigs/controller-tools#828
2. Fix implicit for loop aliasing
- kubernetes-sigs/controller-tools#810
Signed-off-by: Lance Austin <[email protected]>
rick-a-lane-ii
approved these changes
Sep 20, 2023
Alice-Lilith
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps both
controller-runtimeandcontroller-toolsto the latest to ensure we are on the latest k8s deps. The latest version ofcontroller-toolsgenerates slightly modified deep-copy functions that are minor.More info can be found here:
Removed obsolete build tags
Fix implicit for loop aliasing
Related Issues
N/A - normal dep upgrade process
Testing
No additional testing added, CI is green.
Checklist
CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.