✨ Bump dependencies for Kubernetes 1.15.4 #599

joelanford · 2019-09-11T03:25:09Z

Following up on #495, this bumps Kubernetes dependencies to 1.15.4.

k8s-ci-robot · 2019-09-11T03:25:23Z

Hi @joelanford. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mengqiy · 2019-09-16T21:05:46Z

/ok-to-test

alvaroaleman · 2019-09-16T22:00:00Z

At this point it probably makes more sense to wait for Kube 1.16 and then use that, James already created a PR for that: #588

mengqiy · 2019-09-18T00:49:18Z

pkg/client/client.go

@@ -105,7 +105,7 @@ type client struct {
 }

 // resetGroupVersionKind is a helper function to restore and preserve GroupVersionKind on an object.
-// TODO(vincepri): Remove this function and its calls once    controller-runtime dependencies are upgraded to 1.15.
+// TODO(vincepri): Remove this function and its calls once controller-runtime dependencies are upgraded to 1.16?


Can we drop this function?

I thought we could. I removed it in ffe4ab3 and then reverted that change in the next commit after the tests failed. It seems that 1.15 doesn't fix it.

@vincepri Any clues about where we can look to find the upstream change that would allow us to remove this function?

IIRC this is related to apimachinery version. We're at an offsite for the next couple of days so I won't be able to track this down. Are client-go (https://github.com/kubernetes/client-go/blob/master/INSTALL.md#add-client-go-as-a-dependency) and the related dependencies up to date?

joelanford · 2019-10-01T13:39:11Z

Now that Kubernetes 1.16 is GA, I'm in agreement with @alvaroaleman to bump directly to that unless there's a good reason not to. On the operator-sdk side, we're looking to bump to 1.16, so anything we can do to assist in that process, let me know!

I'll leave this open for now, but if there's consensus that its okay to go directly to 1.16, we can close this.

This reverts commit d7d38e8.

joelanford · 2019-10-04T20:56:15Z

@DirectXMan12 I rebased this PR to master, updated to kube 1.15.4, and ran it against a POC go-apidiff tool I put together based on golang.org/x/exp/apidiff

Looks like no incompatible changes, only compatible ones:

$ go-apidiff v0.2.2 k8s-1.15.3
<no output>

As a sanity check, I did commit a branch locally with a breaking change to pkg/log/zap to make sure it would catch it:

$ go-apidiff v0.2.2 break-things

sigs.k8s.io/controller-runtime/pkg/log/zap
  Incompatible changes:
  - New: removed

Lastly, to see what changed in the APIs imported by controller-runtime, we can run with --compare-imports:

$ go-apidiff v0.2.2 k8s-1.15.3 --compare-imports

github.com/prometheus/client_golang/prometheus
  Incompatible changes:
  - (*Timer).ObserveDuration: changed from func() to func() time.Duration
  - DefObjectives: removed
  - Handler: removed
  - InstrumentHandler: removed
  - InstrumentHandlerFunc: removed
  - InstrumentHandlerFuncWithOpts: removed
  - InstrumentHandlerWithOpts: removed
  - UninstrumentedHandler: removed

k8s.io/apimachinery/pkg/runtime
  Incompatible changes:
  - Unstructured.NewEmptyInstance: added

k8s.io/apimachinery/pkg/apis/meta/v1
  Incompatible changes:
  - ListInterface.GetRemainingItemCount: added
  - ListInterface.SetRemainingItemCount: added

k8s.io/apimachinery/pkg/api/meta
  Incompatible changes:
  - k8s.io/apimachinery/pkg/api/meta.List.GetRemainingItemCount: added
  - k8s.io/apimachinery/pkg/api/meta.List.SetRemainingItemCount: added

k8s.io/client-go/util/workqueue
  Incompatible changes:
  - Parallelize: removed

k8s.io/apimachinery/pkg/watch
  Incompatible changes:
  - NewStreamWatcher: changed from func(Decoder) *StreamWatcher to func(Decoder, Reporter) *StreamWatcher

marun · 2019-10-07T22:46:48Z

@joelanford Would you please bump this to 1.16 and perform the same checks for compatibility? There are 2 other PRs proposing to bump to 1.16 but the author of #588 is non-responsive and #618 hasn't been vetted for compatibility.

cc: @DirectXMan12

enxebre · 2019-10-08T06:35:27Z

#618 hasn't been vetted for compatibility.

Just rebased #618 @marun @DirectXMan12 not sure what else is expected there, happy to help to move any of the PRs forward

marun · 2019-10-08T14:13:08Z

#618 hasn't been vetted for compatibility.

Just rebased #618 @marun @DirectXMan12 not sure what else is expected there, happy to help to move any of the PRs forward

See #599 (comment)

DirectXMan12 · 2019-10-10T00:20:34Z

/lgtm
/approve

k8s-ci-robot · 2019-10-10T00:20:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

DirectXMan12 · 2019-10-10T00:20:53Z

as per our discussion in today's meeting :-)

enxebre · 2019-10-10T08:10:47Z

See #599 (comment)

I run the tool here
#618 (comment)

DirectXMan12 · 2019-10-10T22:31:19Z

shoot. This had a whole bunch of extra stuff in it that shouldn't have gotten in there.

DirectXMan12 · 2019-10-10T22:31:33Z

*a whole bunch of extra commits that should've been squashed.

DirectXMan12 · 2019-10-10T22:32:24Z

In the future, please try to avoid merge commits in your PRs

joelanford · 2019-10-10T22:35:43Z

Noted. Sorry about that. I'm used to PR commits getting squashed when the PR is merged.

Use idiomatic gomega syntax in generated tests

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2019

k8s-ci-robot requested review from DirectXMan12 and droot September 11, 2019 03:25

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2019

joelanford force-pushed the k8s-1.15.3 branch from 330d658 to 3319872 Compare September 17, 2019 04:02

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2019

joelanford force-pushed the k8s-1.15.3 branch from e1bc3b9 to d52ba23 Compare September 17, 2019 21:34

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2019

mengqiy reviewed Sep 18, 2019

View reviewed changes

droot assigned DirectXMan12 Sep 23, 2019

joelanford added 5 commits October 4, 2019 12:25

Bump kubernetes dependencies to 1.15.3

df0f06f

remove unnecessary resetGroupVersionKind function and its calls

c0f33bf

Revert "remove unnecessary resetGroupVersionKind function and its calls"

1116b0b

This reverts commit d7d38e8.

change TODO

5a0a15d

bump to kube 1.15.4

18b1edf

joelanford force-pushed the k8s-1.15.3 branch from d52ba23 to 18b1edf Compare October 4, 2019 20:44

joelanford changed the title ~~✨ Bump dependencies for Kubernetes 1.15.3~~ ✨ Bump dependencies for Kubernetes 1.15.4 Oct 4, 2019

Merge branch 'master' into k8s-1.15.3

3738249

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019

k8s-ci-robot merged commit 4ba0a3b into kubernetes-sigs:master Oct 10, 2019

joelanford deleted the k8s-1.15.3 branch October 10, 2019 00:55

joelanford mentioned this pull request Nov 13, 2019

Incorporate API compatibility checks into CI #681

Closed

DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020

Merge pull request #599 from Samze/pr-gomega-tests

8eb2010

Use idiomatic gomega syntax in generated tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Bump dependencies for Kubernetes 1.15.4 #599

✨ Bump dependencies for Kubernetes 1.15.4 #599

joelanford commented Sep 11, 2019 •

edited

Loading

k8s-ci-robot commented Sep 11, 2019

mengqiy commented Sep 16, 2019

alvaroaleman commented Sep 16, 2019

mengqiy Sep 18, 2019

joelanford Sep 18, 2019

vincepri Sep 18, 2019

joelanford commented Oct 1, 2019

joelanford commented Oct 4, 2019 •

edited

Loading

marun commented Oct 7, 2019 •

edited

Loading

enxebre commented Oct 8, 2019 •

edited

Loading

marun commented Oct 8, 2019

DirectXMan12 commented Oct 10, 2019

k8s-ci-robot commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

enxebre commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

joelanford commented Oct 10, 2019

✨ Bump dependencies for Kubernetes 1.15.4 #599

✨ Bump dependencies for Kubernetes 1.15.4 #599

Conversation

joelanford commented Sep 11, 2019 • edited Loading

k8s-ci-robot commented Sep 11, 2019

mengqiy commented Sep 16, 2019

alvaroaleman commented Sep 16, 2019

mengqiy Sep 18, 2019

Choose a reason for hiding this comment

joelanford Sep 18, 2019

Choose a reason for hiding this comment

vincepri Sep 18, 2019

Choose a reason for hiding this comment

joelanford commented Oct 1, 2019

joelanford commented Oct 4, 2019 • edited Loading

marun commented Oct 7, 2019 • edited Loading

enxebre commented Oct 8, 2019 • edited Loading

marun commented Oct 8, 2019

DirectXMan12 commented Oct 10, 2019

k8s-ci-robot commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

enxebre commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

DirectXMan12 commented Oct 10, 2019

joelanford commented Oct 10, 2019

joelanford commented Sep 11, 2019 •

edited

Loading

joelanford commented Oct 4, 2019 •

edited

Loading

marun commented Oct 7, 2019 •

edited

Loading

enxebre commented Oct 8, 2019 •

edited

Loading