Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Bump dependencies for Kubernetes 1.16.2 #588

Closed
wants to merge 1 commit into from

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Sep 7, 2019

Bump dependencies for Kubernetes 1.16.2.

This currently pins to the kubernetes-1.16.2 branch.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 7, 2019
@awesomenix
Copy link
Contributor

@munnerz checking if its still being worked on, our project is going to update to 1.16 soon, would be helpful if this gets merged.

@marun
Copy link
Contributor

marun commented Sep 25, 2019

@munnerz Please update this PR to target kubernetes-1.16.0. controller-tools has already been updated which leaves controller-runtime as the blocker for those using kubebuilder and wanting to update deps to 1.16.

@enxebre
Copy link
Member

enxebre commented Sep 30, 2019

friendly ping @munnerz :)

Signed-off-by: James Munnelly <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2019
@munnerz
Copy link
Member Author

munnerz commented Oct 25, 2019

I've updated this PR to target kubernetes-1.16.2 and rebased on master since Gopkg.* changes 😄

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2019
@munnerz
Copy link
Member Author

munnerz commented Oct 25, 2019

Ah, seems #618 has already merged, but this at least bumps to the .2 patch release 😅 thanks @enxebre!

@k8s-ci-robot
Copy link
Contributor

@munnerz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-controller-runtime-test 402e4d3 link /test pull-controller-runtime-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Oct 25, 2019

I've updated this PR to target kubernetes-1.16.2 and rebased on master since Gopkg.* changes 😄

sweet! probably want to update the PR desc as well

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@DirectXMan12 DirectXMan12 changed the title ✨ Bump dependencies for Kubernetes 1.16 ✨ Bump dependencies for Kubernetes 1.16.2 Nov 6, 2019
@DirectXMan12
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
@DirectXMan12
Copy link
Contributor

updated the PR desc, but looks like tests are failing

@munnerz
Copy link
Member Author

munnerz commented Dec 17, 2019

Closing in favour of #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants