🐛 metadata client applies patch options

[furkhat]

Signed-off-by: Furkhat Kasymovgeniiuulu [email protected]

Patch options provided by caller are not ignored. Fixes #1507

[k8s-ci-robot]

Welcome @furkhat!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @furkhat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alvaroaleman]

@furkhat thanks! Could you please add a test for this?

[furkhat]

Sure, I will add test for this.

[furkhat]

There seems to be no tests for Patch. Is this "technical dept" or there were other reasons to not add tests?

It also puzzles me that metadata client has PatchStatus method. How that would work? I would guess that this was added just to satisfy interface, otherwise I don't know.

[alvaroaleman]

There seems to be no tests for Patch. Is this "technical dept" or there were other reasons to not add tests?

Seems to be an oversight.

It also puzzles me that metadata client has PatchStatus method. How that would work? I would guess that this was added just to satisfy interface, otherwise I don't know.

Why would it not work? Not being able to retrieve the status doesn't mean you can't set it.

[furkhat]

Not being able to retrieve the status doesn't mean you can't set it.

I am sorry I could not understand, what are you referring here?

Let me elaborate on what puzzles me. I think PatchStatus of metadata client would not work because the object passed to PatchStatus is always metav1.PartialObjectMetadata which AFAIK doesn't have any fields associated with "status".

[alvaroaleman]

I think PatchStatus of metadata client would not work because the object passed to PatchStatus is always metav1.PartialObjectMetadata which AFAIK doesn't have any fields associated with "status"

No, it takes a client.Object. I agree that in all practical terms this is of limited use, as someone would need to construct an object with a status by themselves, they can not get it through the client.

[furkhat]

I agree that in all practical terms this is of limited use, as someone would need to construct an object with a status by themselves, they can not get it through the client.

No I don't mean that. I mean that according to code to trigger metadata client's PatchStatus the client.Object must be of *metav1.PartialObjectMetadata and I don't understand the the use..

Here

• https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/metadata_client.go#{L169:L172} - exits with error if type isn't *metav1.PartialObjectMetadata
• https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/client.go#L259-L260 - calls metadata_client.PatchStatus only if type is *metav1.PartialObjectMetadata

[alvaroaleman]

@furkhat ok sure, feel free to open an issue for that. It is unrelated to this PR though, isn't it?

[furkhat]

It is unrelated to this PR though, isn't it?

PatchStatus doesn't apply patch options it receives in the same way so I wanted to fix it too.. I opened the issue #1514

[alvaroaleman]

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, furkhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment