-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No use for metadata_client.PatchStatus #1514
Comments
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
/assign |
/unassign MadhavJivrajani |
/close |
@furkhat: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Metadata client's PatchStatus receives client.Object that must be of *metav1.PartialObjectMetadata type which seems useless because PartialObjectMetadata doesn't have fields that describe status.
Here
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/metadata_client.go#{L169:L172} - exits with error if type isn't *metav1.PartialObjectMetadata
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.8.3/pkg/client/client.go#L259-L260 - calls metadata_client.PatchStatus only if type is *metav1.PartialObjectMetadata
The text was updated successfully, but these errors were encountered: