Controller-runtime does not compile with client-go 1.31 with version v0.18.5 #2925

howardjohn · 2024-08-13T20:33:51Z

Reproducer:

main.go:

package main

import (
        _ "k8s.io/client-go"
        _ "sigs.k8s.io/controller-runtime/pkg/client/fake"
)

func main() {
}

go.mod:

module test

go 1.22.6

require sigs.k8s.io/controller-runtime v0.18.5

require k8s.io/client-go v0.31.0

Gives:

$ go build .
# sigs.k8s.io/controller-runtime/pkg/client/fake
/home/john/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/fake/client.go:858:29: cannot use c.tracker (variable of type versionedTracker) as "k8s.io/client-go/testing".ObjectTracker value in argument to dryPatch: versionedTracker does not implement "k8s.io/client-go/testing".ObjectTracker (wrong type for method Create)
                have Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string) error
                want Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string, ..."k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions) error
/home/john/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/fake/client.go:872:37: cannot use c.tracker (variable of type versionedTracker) as "k8s.io/client-go/testing".ObjectTracker value in argument to testing.ObjectReaction: versionedTracker does not implement "k8s.io/client-go/testing".ObjectTracker (wrong type for method Create)
                have Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string) error
                want Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string, ..."k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions) error

The text was updated successfully, but these errors were encountered:

howardjohn · 2024-08-13T20:34:54Z

Broken by kubernetes/kubernetes#125560

howardjohn · 2024-08-13T20:39:44Z

In the past sometimes we have done tricks to support both versions concurrently. I don't see how we can do it in this case

dims · 2024-08-13T20:49:14Z

cc @jpbetz @liggitt

danielvegamyhre · 2024-08-13T20:54:10Z

I am impacted by this as well.

sbueringer · 2024-08-13T21:00:11Z

While this is not great, it is not something that we guarantee to support, see: https://github.com/kubernetes-sigs/controller-runtime#compatibility

jpbetz · 2024-08-13T21:15:10Z

Can anyone impacted verify that if they upgrade client-go into the supported skew range that the problem is resolved?

howardjohn · 2024-08-13T21:18:01Z

Ah I looked for a newer CR release but didn't see it since where I was looking filtered out 0.19 due to the -beta suffix. At least in my example reproducer that does seem to compile.

sbueringer · 2024-08-13T21:19:25Z

Ah, makes sense! Yup 0.19 would be the correct release for k8s.io/* 1.31.0

I think we'll release it soon. Last thing we want to get done before is this one: #2901 (at least as far as I'm aware)

sbueringer · 2024-08-13T21:21:44Z

Related Slack thread: https://kubernetes.slack.com/archives/CHGFYJVAN/p1723581467467729

dims · 2024-08-13T21:37:23Z

I think we'll release it soon.

thanks @sbueringer !

davidkarlsen · 2024-08-17T20:07:16Z

Hm, when I use 0.19, I get this problem: https://github.com/davidkarlsen/flyway-operator/actions/runs/10406586858/job/28819954478

liggitt · 2024-08-17T20:35:17Z

Hm, when I use 0.19, I get this problem: https://github.com/davidkarlsen/flyway-operator/actions/runs/10406586858/job/28819954478

that CI run is still referencing 0.29.0 versions of some kubernetes libraries, I think there's a version mismatch there or they have not all been bumped to 0.31.0 consistently

go: downloading k8s.io/apiextensions-apiserver v0.29.0
go: downloading k8s.io/apimachinery v0.29.0

davidkarlsen · 2024-08-17T20:37:08Z

I figured out it was my controller-gen tooling being outdated.

troy0820 · 2024-08-19T21:01:33Z

/retitle Controller-runtime does not compile with client-go 1.31 with version v0.18.5

Do we still need this open? I believe we released v0.19.0 and it works along with the table @sbueringer created on the README.

howardjohn · 2024-08-19T22:54:36Z

From my POV good to close

troy0820 · 2024-08-19T23:40:14Z

/close

k8s-ci-robot · 2024-08-19T23:40:19Z

@troy0820: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

To increase flexibility for downstream consumers, we set a lower Go version in `go.mod` for API/CLIENT modules (nsx-operator/pkg/apis, nsx-operator/pkg/client), allowing them to choose their preferred Go version. However, we will keep the main module (nsx-operator) on the latest Go version. Currently, we set Go 1.21 for the API module and Go 1.22 for CLIENT module due to dependencies. Update controller-runtime to v0.19.0 for this issue: kubernetes-sigs/controller-runtime#2925 Update controller-gen to v16.5 to resolve the error below. ``` /Users/hsuy/Desktop/nsx-operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="github.com/vmware-tanzu/nsx-operator/pkg/apis/legacy/v1alpha1" output:crd:artifacts:config=build/yaml/crd/legacy/ /Users/hsuy/go/pkg/mod/k8s.io/[email protected]/core/v1/doc.go:21:1: missing argument "" (at <input>) /Users/hsuy/go/pkg/mod/k8s.io/[email protected]/core/v1/doc.go:21:1: missing argument "" (at <input>) k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ConditionStatus k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ConditionStatus github.com/vmware-tanzu/nsx-operator/pkg/apis/legacy/v1alpha1:-: unable to locate schema for type "k8s.io/api/core/v1".ConditionStatus ``` Signed-off-by: Yun-Tang Hsu <[email protected]>

In order to ensure TLS 1.3 is supportted. We bump Golang version to 1.23.1 In this patch, we do: 1. Bump golangci to v1.61.0 in order to support golang v1.23.1 2. To increase flexibility for downstream consumers, we set a lower Go version in `go.mod` for API module (nsx-operator/pkg/apis), allowing them to choose their preferred Go version. However, we will keep the main module (nsx-operator) on the latest Go version. Currently, we set Go 1.21 for the API module. 3. Update controller-runtime to v0.19.0 for this issue: kubernetes-sigs/controller-runtime#2925 4. Update controller-gen to v16.5 to resolve the error below. ``` /Users/hsuy/Desktop/nsx-operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="github.com/vmware-tanzu/nsx-operator/pkg/apis/legacy/v1alpha1" output:crd:artifacts:config=build/yaml/crd/legacy/ /Users/hsuy/go/pkg/mod/k8s.io/[email protected]/core/v1/doc.go:21:1: missing argument "" (at <input>) /Users/hsuy/go/pkg/mod/k8s.io/[email protected]/core/v1/doc.go:21:1: missing argument "" (at <input>) k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ConditionStatus k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".ConditionStatus github.com/vmware-tanzu/nsx-operator/pkg/apis/legacy/v1alpha1:-: unable to locate schema for type "k8s.io/api/core/v1".ConditionStatus ``` Signed-off-by: Yun-Tang Hsu <[email protected]>

kubernetes-sigs/controller-runtime#2925

howardjohn changed the title ~~Does not compile with Go 1.31~~ Does not compile with client-go 1.31 Aug 13, 2024

vishwahiremat mentioned this issue Aug 14, 2024

Bump the all group across 1 directory with 10 updates radius-project/radius#7808

Closed

danielvegamyhre mentioned this issue Aug 14, 2024

Release v0.6.0 requirements kubernetes-sigs/jobset#523

Closed

13 tasks

sbueringer mentioned this issue Aug 14, 2024

Does not compile with apimachinery 1.31 #2927

Closed

fmuyassarov mentioned this issue Aug 14, 2024

go.mod: bump kubernetes to v1.31 kubernetes-sigs/node-feature-discovery#1837

Merged

lucacome mentioned this issue Aug 14, 2024

Bump sigs.k8s.io/controller-tools from 0.15.0 to 0.16.1 nginxinc/nginx-gateway-fabric#2402

Merged

davidkarlsen mentioned this issue Aug 15, 2024

Bump k8s.io/client-go from 0.30.3 to 0.31.0 davidkarlsen/flyway-operator#156

Closed

k8s-ci-robot changed the title ~~Does not compile with client-go 1.31~~ Controller-runtime does not compile with client-go 1.31 with version v0.18.5 Aug 19, 2024

k8s-ci-robot closed this as completed Aug 19, 2024

yuntanghsu mentioned this issue Nov 11, 2024

Bump Golang to 1.23.1 vmware-tanzu/nsx-operator#877

Merged

yuntanghsu mentioned this issue Nov 14, 2024

[CP]Bump Golang to 1.23.1 vmware-tanzu/nsx-operator#892

Merged

AnnaZivkovic added a commit to AnnaZivkovic/multiarch-manager-operator that referenced this issue Dec 23, 2024

Updated sigs.k8s.io/controller-runtime v0.18.5->v0.19.3

1d2465f

kubernetes-sigs/controller-runtime#2925

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Controller-runtime does not compile with client-go 1.31 with version v0.18.5 #2925

Controller-runtime does not compile with client-go 1.31 with version v0.18.5 #2925

howardjohn commented Aug 13, 2024

howardjohn commented Aug 13, 2024

howardjohn commented Aug 13, 2024

dims commented Aug 13, 2024

danielvegamyhre commented Aug 13, 2024

sbueringer commented Aug 13, 2024

jpbetz commented Aug 13, 2024

howardjohn commented Aug 13, 2024

sbueringer commented Aug 13, 2024 •

edited

Loading

sbueringer commented Aug 13, 2024

dims commented Aug 13, 2024

davidkarlsen commented Aug 17, 2024

liggitt commented Aug 17, 2024

davidkarlsen commented Aug 17, 2024

troy0820 commented Aug 19, 2024

howardjohn commented Aug 19, 2024

troy0820 commented Aug 19, 2024

k8s-ci-robot commented Aug 19, 2024

Controller-runtime does not compile with client-go 1.31 with version v0.18.5 #2925

Controller-runtime does not compile with client-go 1.31 with version v0.18.5 #2925

Comments

howardjohn commented Aug 13, 2024

howardjohn commented Aug 13, 2024

howardjohn commented Aug 13, 2024

dims commented Aug 13, 2024

danielvegamyhre commented Aug 13, 2024

sbueringer commented Aug 13, 2024

jpbetz commented Aug 13, 2024

howardjohn commented Aug 13, 2024

sbueringer commented Aug 13, 2024 • edited Loading

sbueringer commented Aug 13, 2024

dims commented Aug 13, 2024

davidkarlsen commented Aug 17, 2024

liggitt commented Aug 17, 2024

davidkarlsen commented Aug 17, 2024

troy0820 commented Aug 19, 2024

howardjohn commented Aug 19, 2024

troy0820 commented Aug 19, 2024

k8s-ci-robot commented Aug 19, 2024

sbueringer commented Aug 13, 2024 •

edited

Loading