-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 🐛 Allow unsetting useExperimentalRetryJoin field from KubeadmControlPlane #9202
[release-1.5] 🐛 Allow unsetting useExperimentalRetryJoin field from KubeadmControlPlane #9202
Conversation
….kubeadmConfigSpec
Hi @MaxFedotov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer sorry for easy CLA errors and other stuff, I accidentally used main branch for merge and updated It after |
/check-cla |
@MaxFedotov No problem, not sure if there is a way for us to fix it without re-opening the PR |
Thx! /lgtm |
LGTM label has been added. Git tree hash: 99af7783bca7d5dfe21aace393ddd836ad19d48c
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This is a cherry-pick of changes merged in #9170 to
release-1.5
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9169