Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.4] 🐛 Increase timeout for clusterclass rollout test #8937

Merged
merged 1 commit into from
Jun 29, 2023
Merged

[release-1.4] 🐛 Increase timeout for clusterclass rollout test #8937

merged 1 commit into from
Jun 29, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #8897

/assign killianmuldoon

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 29, 2023
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jun 29, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2023
@killianmuldoon
Copy link
Contributor

Link to flaking test: https://storage.googleapis.com/k8s-triage/index.html?job=.*-cluster-api-.*1.4&xjob=.*-provider-.*#7b3ebfaf894e9e2e1fe0

Not sure what merged on release-1.4 to make this flake pop up there. The only candidates timing wise are pulls related to the Kind mapper.

That said, I don't think this specific action slowing down is particularly important, so we should be happy to backport this change to the test expectation - the same as has been done in main.

killianmuldoon
killianmuldoon reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Jun 29, 2023
@sbueringer
Copy link
Member

/lgtm
/approve

Sounds okay!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d272a91a41120696fdfdb803fb26e9675065bcd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7137119 into kubernetes-sigs:release-1.4 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @killianmuldoon @sbueringer @k8s-ci-robot