🐛 Increase timeout for clusterclass rollout test #8897
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
killianmuldoon
changed the title
|
/area e2e-testing |
| @@ -279,7 +279,7 @@ func assertClusterObjects(ctx context.Context, clusterProxy framework.ClusterPro | |||
| assertMachineSetsMachines(g, clusterObjects, cluster) | |||
|
|
|||
| By("All cluster objects have the right labels, annotations and selectors") | |||
| }, 10*time.Second, 1*time.Second).Should(Succeed()) | |||
| }, 30*time.Second, 1*time.Second).Should(Succeed()) | |||
There was a problem hiding this comment.
@sbueringer do you know of any changes recently that could have caused this? The flake only popped up on June 16.
There was a problem hiding this comment.
Hm. This one was on 12.06: https://github.com/kubernetes-sigs/cluster-api/pull/8743/files
There was a problem hiding this comment.
But totally different controller
There was a problem hiding this comment.
Let's go ahead with the slightly longer timeout as it doesn't actually matter if the annotation shows up after 10 seconds or 10 hours. Let's take a closer look if the flake persists
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e73075de2bc792d19a3a08a8d1f9ea1c27ced354
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
Interesting flake /retest |
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
pr-increase-cluster-rollout-timeout
branch
from
c3a6c96 to
50f8991
Compare
killianmuldoon
changed the title
killianmuldoon
changed the title
|
/cherry-pick release-1.4 This issue is now cropping up on 1.4. I'm not sure of the root cause as there have not been many commits to that branch. |
|
@killianmuldoon: new pull request created: #8937 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Increase the timeout for the comparisons in this test to see if they have an impact on the flake in #8747
I'm not certain what's causing the drop in speed here, but looking at the artifacts of the failing tests the cert annotation is correctly reconciled on the control plane machine, but this happens after the timeout completes.