-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Removing deprecated healthcheck condition #7836
⚠️ Removing deprecated healthcheck condition #7836
Conversation
Is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for this!
LGTM label has been added. Git tree hash: 809aeb8638c02dfe83dd6521ad87bda2081ed0db
|
yes, this is an informing job that signal when we are doing an API change, which is expected in this PR (but not in others). |
could you kindly add one line for this change in https://main.cluster-api.sigs.k8s.io/developer/providers/v1.3-to-v1.4.html#removals (this is a doc provider look at when upgrading)? |
cdd7158
to
4011b2d
Compare
@knabben: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 45c61f588d3b288268bbcb3f9034d4a12a83853c
|
What this PR does / why we need it:
Cleanup of the deprecated
MachineHealthCheckSuccededCondition
condition in the v1beta1 API.Should use the MachineHealthCheckSucceededCondition
variable intead.
There's no changes in the documentation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Subtask of #7713