Tracking issue for dropping code deprecated in v1.3 release #7713

ykakarap · 2022-12-08T22:46:29Z

The following parts of the code base were deprecated in the previous release (v1.3). This is a tracking issue for all the work that needs to be done to drop all the deprecated work:

Drop MachineHealthCheckSuccededCondition in api/v1beta1/condition_consts.go (@knabben)
- Drop the constant and make sure to replace all uses, if any, with MachineHealthCheckSucceededCondition
- Update the in book.
Drop clusterctl backup command (@oscr)
- This command was deprecated in favor of clusterctl move --to-directory.
- Drop the file cmd/clusterctl/cmd/backup.go
- Drop the Backup(options BackupOptions) error method from the Client interface and the implementations of this interface: clusterctlClient and fakeClient
- Drop BackupOptions from cmd/clusterctl/client/move.go
- Drop Backup(namespace string, directory string) error method from the ObjectMover interface and the implementations of this interface: objectMover and fakeObjectMover
- Update in book.
Drop clusterctl restore command (@hackeramitkumar )
- This command was deprecated in favor of clusterctl move --from-directory.
- Drop the file cmd/clusterctl/cmd/restore.go
- Drop the Restore(options RestoreOptions) error method from the Client interface and the implementations of this interface: clusterctlClient and fakeClient
- Drop RestoreOptions from cmd/clusterctl/client/move.go
- Drop Restore(namespace string, directory string) error method from the ObjectMover interface and the implementations of this interface: objectMover and fakeObjectMover
- Update in book.
Drop the --disable-no-echo flag in clusterctl describe command. (@knabben)
- Drop the corresponding variable (disableNoEcho ) and its uses from the file.
- Update in book.
Drop the --list-images flag in clusterctl init command. (@knabben)
- Drop the corresponding variable listImages and its uses from the file.
- Update in book.
Drop CloneTemplate and CloneTemplateInput (@knabben)
- Replace its uses, if any, with CreateFromTemplate and CreateFromTemplateInput
- Update in book.
Drop NewServer in exp/runtime/server/server.go (@knabben)
- Replace its uses, if any, with New
- Update in book.
Drop ClusterTopologyManagedFieldsAnnotation (@knabben)
- Drop all of this uses.
- Update in book.

The text was updated successfully, but these errors were encountered:

oscr · 2022-12-12T09:08:46Z

@ykakarap I suggest making each item it's own ticket and using this ticket as an overview. Then each ticket can be discussed and assigned separately, to avoid having multiple people working on the same task. I also suggest each item should include updating the docs :)

ykakarap · 2022-12-12T16:27:51Z

@ykakarap I suggest making each item it's own ticket and using this ticket as an overview.

That is the intention 🙂. I will leave it to whoever picks up an item to create a PR and if they want an issue to go with it.

I also suggest each item should include updating the docs :)

+1

ykakarap · 2022-12-12T18:52:02Z

/help

k8s-ci-robot · 2022-12-12T18:52:03Z

@ykakarap:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fabriziopandini · 2022-12-14T16:34:38Z

/triage accepted

chiukapoor · 2022-12-16T18:52:27Z

Hello Team, I will work on the task to Drop clusterctl restore command

oscr · 2022-12-16T20:49:49Z

@chiukapoor Great to hear! I suspect you should be able to look at #7752 for inspiration. Note the apidiff test will fail for your pr and this is expected.

chiukapoor · 2022-12-19T06:01:58Z

Sure @oscr, will refer to #7752 :)

/assign

sbueringer · 2023-01-02T14:41:28Z

@ykakarap Just a note. For some of the sub-tasks we have to update .golangci.yaml. Can you please add that to the respective sub-tasks? (e.g.

cluster-api/.golangci.yml

Lines 222 to 225 in de575ca

    
           # Specific exclude rules for deprecated fields that are still part of the codebase. These should be removed as the referenced deprecated item is removed from the project. 
        
           - linters: 
        
               - staticcheck 
        
             text: "SA1019: (bootstrapv1.ClusterStatus|clusterv1.ClusterTopologyManagedFieldsAnnotation|scope.Config.Spec.UseExperimentalRetryJoin|DockerMachine.Spec.Bootstrapped|machineStatus.Bootstrapped) is deprecated"

)

knabben · 2023-01-03T14:59:47Z

hey, I will get these subtasks, PRs follows -

Drop MachineHealthCheckSuccededCondition in api/v1beta1/condition_consts.go. - ⚠️ Removing deprecated healthcheck condition #7836
Drop the --list-images flag in clusterctl init command. - ⚠️ Removing deprecated (--disable-no-echo) flag and renaming docs #7837
Drop the --disable-no-echo flag in clusterctl describe command. - ⚠️ Removing deprecated --list-images flag on init command #7838
Drop CloneTemplate and CloneTemplateInput - ⚠️ Removing CloneTemplate and CloneTemplateInput #7839
Drop NewServer in exp/runtime/server/server.go - ⚠️ Removing deprecated NewServer function #7844
Drop ClusterTopologyManagedFieldsAnnotation - ⚠️ Drop ClusterTopologyManagedFieldsAnnotation field from v1beta1 #7845

knabben · 2023-01-04T16:01:48Z

/reopen

k8s-ci-robot · 2023-01-04T16:01:52Z

@knabben: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sbueringer · 2023-01-05T05:57:42Z

Quick update: after recent PRs that now only leaves the removal of clusterctl restore

ykakarap · 2023-01-06T00:05:53Z

Looks like @chiukapoor Is already assigned to that item. Once that is done I will close this issue.

hackeramitkumar · 2023-01-06T07:13:02Z

@chiukapoor are you working on 'clusterctl restore' task?? If not then I can take it.

chiukapoor · 2023-01-06T07:30:49Z

Hey @hackeramitkumar, I have started the work will push changes in couple of days.

hackeramitkumar · 2023-01-06T08:48:12Z

@chiukapoor , thank you

Hey @hackeramitkumar, I have started the work will push changes in couple of days.

hackeramitkumar · 2023-01-18T17:44:00Z

@chiukapoor are you still working on cluster restore task? Actually we have to done it before the next patch release.

sbueringer · 2023-01-18T19:24:37Z

@chiukapoor are you still working on cluster restore task? Actually we have to done it before the next patch release.

We don't have to do it before the next patch release as the change will be done on main and the next release "from main" will be the first v1.4 beta.

ykakarap · 2023-01-18T19:45:26Z

Echoing what @sbueringer said, this does not block the next v1.3 and v1.2 patch releases.

It would just be nice to get done to close the deprecation work on main. 🙂

sbueringer · 2023-01-19T11:05:51Z

Thx @hackeramitkumar for taking over the last part.

Thx everyone!

/close

k8s-ci-robot · 2023-01-19T11:05:55Z

@sbueringer: Closing this issue.

In response to this:

Thx @hackeramitkumar for taking this over.

Thx everyone!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ykakarap · 2023-01-19T17:05:10Z

Thank you everyone who worked on this issue! 🙏🏼

fabriziopandini · 2023-01-19T20:11:41Z

dream team!

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 8, 2022

k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 12, 2022

oscr mentioned this issue Dec 13, 2022

⚠️ Remove clusterctl backup command and Backup function from Client interface #7752

Merged

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2022

k8s-ci-robot assigned chiukapoor Dec 19, 2022

k8s-ci-robot closed this as completed in #7837 Jan 4, 2023

k8s-ci-robot reopened this Jan 4, 2023

ykakarap mentioned this issue Jan 7, 2023

Tasks for v1.4 release cycle #7672

Closed

31 tasks

hackeramitkumar mentioned this issue Jan 18, 2023

⚠️ Remove clusterctl restore command and Restore function from Client interface #7945

Merged

k8s-ci-robot closed this as completed Jan 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for dropping code deprecated in v1.3 release #7713

Tracking issue for dropping code deprecated in v1.3 release #7713

ykakarap commented Dec 8, 2022 •

edited by sbueringer

Loading

oscr commented Dec 12, 2022

ykakarap commented Dec 12, 2022

ykakarap commented Dec 12, 2022

k8s-ci-robot commented Dec 12, 2022

fabriziopandini commented Dec 14, 2022

chiukapoor commented Dec 16, 2022

oscr commented Dec 16, 2022

chiukapoor commented Dec 19, 2022

sbueringer commented Jan 2, 2023 •

edited

Loading

knabben commented Jan 3, 2023 •

edited

Loading

knabben commented Jan 4, 2023

k8s-ci-robot commented Jan 4, 2023

sbueringer commented Jan 5, 2023 •

edited

Loading

ykakarap commented Jan 6, 2023

hackeramitkumar commented Jan 6, 2023

chiukapoor commented Jan 6, 2023

hackeramitkumar commented Jan 6, 2023

hackeramitkumar commented Jan 18, 2023

sbueringer commented Jan 18, 2023 •

edited

Loading

ykakarap commented Jan 18, 2023

sbueringer commented Jan 19, 2023 •

edited

Loading

k8s-ci-robot commented Jan 19, 2023

ykakarap commented Jan 19, 2023

fabriziopandini commented Jan 19, 2023

Tracking issue for dropping code deprecated in v1.3 release #7713

Tracking issue for dropping code deprecated in v1.3 release #7713

Comments

ykakarap commented Dec 8, 2022 • edited by sbueringer Loading

oscr commented Dec 12, 2022

ykakarap commented Dec 12, 2022

ykakarap commented Dec 12, 2022

k8s-ci-robot commented Dec 12, 2022

Guidelines

fabriziopandini commented Dec 14, 2022

chiukapoor commented Dec 16, 2022

oscr commented Dec 16, 2022

chiukapoor commented Dec 19, 2022

sbueringer commented Jan 2, 2023 • edited Loading

knabben commented Jan 3, 2023 • edited Loading

knabben commented Jan 4, 2023

k8s-ci-robot commented Jan 4, 2023

sbueringer commented Jan 5, 2023 • edited Loading

ykakarap commented Jan 6, 2023

hackeramitkumar commented Jan 6, 2023

chiukapoor commented Jan 6, 2023

hackeramitkumar commented Jan 6, 2023

hackeramitkumar commented Jan 18, 2023

sbueringer commented Jan 18, 2023 • edited Loading

ykakarap commented Jan 18, 2023

sbueringer commented Jan 19, 2023 • edited Loading

k8s-ci-robot commented Jan 19, 2023

ykakarap commented Jan 19, 2023

fabriziopandini commented Jan 19, 2023

ykakarap commented Dec 8, 2022 •

edited by sbueringer

Loading

sbueringer commented Jan 2, 2023 •

edited

Loading

knabben commented Jan 3, 2023 •

edited

Loading

sbueringer commented Jan 5, 2023 •

edited

Loading

sbueringer commented Jan 18, 2023 •

edited

Loading

sbueringer commented Jan 19, 2023 •

edited

Loading