Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] 🌱 KCP should avoid to reconcile certificates too early #7744

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #7727

/assign fabriziopandini

@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2022
@fabriziopandini
Copy link
Member

/retest

1 similar comment
@ykakarap
Copy link
Contributor

/retest

@ykakarap
Copy link
Contributor

Netlify is currently having pipeline issues: https://www.netlifystatus.com/

One it is back to green we should re-trigger the jobs. /retest does not seem to re-trigger the Netlify jobs. These might need to be manually triggered using the "re-run jobs" button in github.

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Netlify jobs failure is not related to this PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@fabriziopandini fabriziopandini force-pushed the cherry-pick-7727-to-release-1.3 branch from ba85c18 to 8bf5d8a Compare December 13, 2022 19:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@ykakarap
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@ykakarap
Copy link
Contributor

/retest

2 similar comments
@ykakarap
Copy link
Contributor

/retest

@ykakarap
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit ef38ad0 into kubernetes-sigs:release-1.3 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants