-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 KCP should avoid to reconcile certificates too early #7727
🌱 KCP should avoid to reconcile certificates too early #7727
Conversation
5d115c5
to
107212e
Compare
107212e
to
9ce7e66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Should this be cherry-picked to 1.3 as a bugfix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
self approve given two lgtm + this will allows us to start making final tests for the patch release |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.3 |
@fabriziopandini: new pull request created: #7744 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.2 |
@fabriziopandini: #7727 failed to apply on top of branch "release-1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note: this should not be backported to 1.2 because certificate remediation was introduced in 1.3 only |
What this PR does / why we need it:
This PR prevents KCP to reconcile certificate expiration if the control plane is not yet initialized, thus getting rid of some noisy errors in the logs.