Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 KCP should avoid to reconcile certificates too early #7727

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR prevents KCP to reconcile certificate expiration if the control plane is not yet initialized, thus getting rid of some noisy errors in the logs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2022
@fabriziopandini fabriziopandini force-pushed the KCP-should-avoid-early-reconcile-certificates branch from 5d115c5 to 107212e Compare December 12, 2022 14:02
@fabriziopandini fabriziopandini force-pushed the KCP-should-avoid-early-reconcile-certificates branch from 107212e to 9ce7e66 Compare December 12, 2022 14:18
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@killianmuldoon
Copy link
Contributor

Should this be cherry-picked to 1.3 as a bugfix?

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member Author

self approve given two lgtm + this will allows us to start making final tests for the patch release
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 59aa8e4 into kubernetes-sigs:main Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Dec 13, 2022
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #7744

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@fabriziopandini: #7727 failed to apply on top of branch "release-1.2":

Applying: KCP should avoid to reconcile certificates too early
Using index info to reconstruct a base tree...
M	controlplane/kubeadm/internal/controllers/controller.go
M	controlplane/kubeadm/internal/controllers/controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging controlplane/kubeadm/internal/controllers/controller_test.go
CONFLICT (content): Merge conflict in controlplane/kubeadm/internal/controllers/controller_test.go
Auto-merging controlplane/kubeadm/internal/controllers/controller.go
CONFLICT (content): Merge conflict in controlplane/kubeadm/internal/controllers/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 KCP should avoid to reconcile certificates too early
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member Author

Note: this should not be backported to 1.2 because certificate remediation was introduced in 1.3 only

@fabriziopandini fabriziopandini deleted the KCP-should-avoid-early-reconcile-certificates branch December 15, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants